You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/23 10:50:05 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9619: [charts] Improve performance on GET list
codecov-io edited a comment on issue #9619:
URL: https://github.com/apache/incubator-superset/pull/9619#issuecomment-618330921
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9619?src=pr&el=h1) Report
> Merging [#9619](https://codecov.io/gh/apache/incubator-superset/pull/9619?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/76764acfc16ef16583dcad30472d93346deaa796&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9619?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9619 +/- ##
==========================================
- Coverage 65.71% 65.55% -0.16%
==========================================
Files 574 574
Lines 30135 30138 +3
Branches 3066 3066
==========================================
- Hits 19802 19758 -44
- Misses 10149 10196 +47
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.76% <ø> (ø)` | |
| #python | `70.33% <71.42%> (-0.27%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9619?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.66% <ø> (ø)` | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `84.69% <71.42%> (-0.86%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/9619/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9619?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9619?src=pr&el=footer). Last update [76764ac...2cc7494](https://codecov.io/gh/apache/incubator-superset/pull/9619?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org