You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by linwen <gi...@git.apache.org> on 2016/04/07 12:33:04 UTC
[GitHub] incubator-hawq pull request: HAWQ-637. Fix RM process error if pro...
GitHub user linwen opened a pull request:
https://github.com/apache/incubator-hawq/pull/565
HAWQ-637. Fix RM process error if property is missing or invalid in h…
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/linwen/incubator-hawq hawq-637
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/565.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #565
----
commit fda5929b784bcd39458dc6b0dec9d7617110dc38
Author: Wen Lin <wl...@pivotal.io>
Date: 2016-04-07T10:30:42Z
HAWQ-637. Fix RM process error if property is missing or invalid in hawq-site.xml with Yarn mode.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-637. Fix RM process error if pro...
Posted by linwen <gi...@git.apache.org>.
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/565
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-637. Fix RM process error if pro...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/565#issuecomment-207183443
@jiny2:
1. For critical parameters that might make RM unable to start if incorrect value is specified, we need to error out while loading them. This makes user be aware of critical configuration issues as early as possible (at hawq start stage, etc).
2. While for parameters that its correctness is not so obvious, we can use the fix in this change to postpone it to runtime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-637. Fix RM process error if pro...
Posted by jiny2 <gi...@git.apache.org>.
Github user jiny2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/565#issuecomment-207179261
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---