You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by "Weiwei Yang (Jira)" <ji...@apache.org> on 2021/01/18 21:49:00 UTC

[jira] [Created] (YUNIKORN-510) Remove the sleep in placeholder manager stop function

Weiwei Yang created YUNIKORN-510:
------------------------------------

             Summary: Remove the sleep in placeholder manager stop function
                 Key: YUNIKORN-510
                 URL: https://issues.apache.org/jira/browse/YUNIKORN-510
             Project: Apache YuniKorn
          Issue Type: Sub-task
          Components: shim - kubernetes
            Reporter: Weiwei Yang


There is a 3s sleep in the stop function of placeholder manager, per Tingyao:

"When we send the struct{}{} to stopChan, the Start() might not set Running to false immediately. Or we can move sleep to TestPlaceholderManagerStartStop(), which is located in placeholder_manager_test.go."

We should remove this from the stop function and move this to the UT code.





--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org