You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Takeshi Yamamuro (Jira)" <ji...@apache.org> on 2019/10/29 12:43:00 UTC

[jira] [Commented] (SPARK-27763) Port test cases from PostgreSQL to Spark SQL

    [ https://issues.apache.org/jira/browse/SPARK-27763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961970#comment-16961970 ] 

Takeshi Yamamuro commented on SPARK-27763:
------------------------------------------

Hi, all,

I've checked the other left (not-merged-yet) regressions tests in PgSQL: [https://github.com/postgres/postgres/tree/REL_12_STABLE/src/test/regress/sql]

In my opinion, there are more five tests (see a list in the bottom) that we need to check for porting,
 because they are more basic ones than the others.

If there is no problem for that, I'll check the left five tests (make PRs if necessary) then
 resolve this parent issue as resolved.

WDYT? [~smilegator] [~dongjoon] [~hyukjin.kwon] [~yumwang]

 
{code:java}
-- the left regression tests we need to check
alter_table.sql
create_table.sql
groupingsets.sql
insert.sql
limit.sql

-- the regression tests we don't port now
advisory_lock.sql
alter_generic.sql
alter_operator.sql
amutils.sql
arrays.sql
async.sql
bit.sql
bitmapops.sql
box.sql
brin.sql
btree_index.sql
char.sql
circle.sql
cluster.sql
collate.icu.utf8.sql
collate.linux.utf8.sql
collate.sql
combocid.sql
conversion.sql
copy2.sql
copydml.sql
copyselect.sql
create_aggregate.sql
create_am.sql
create_cast.sql
create_function_3.sql
create_index.sql
create_index_spgist.sql
create_misc.sql
create_operator.sql
create_procedure.sql
create_table_like.sql
create_type.sql
dbsize.sql
delete.sql
dependency.sql
domain.sql
drop_if_exists.sql
drop_operator.sql
enum.sql
equivclass.sql
errors.sql
event_trigger.sql
expressions.sql
fast_default.sql
foreign_data.sql
foreign_key.sql
functional_deps.sql
generated.sql
geometry.sql
gin.sql
gist.sql
guc.sql
hash_func.sql
hash_index.sql
hash_part.sql
horology.sql
hs_primary_extremes.sql
hs_primary_setup.sql
hs_standby_allowed.sql
hs_standby_check.sql
hs_standby_disallowed.sql
hs_standby_functions.sql
identity.sql
index_including.sql
index_including_gist.sql
indexing.sql
indirect_toast.sql
inet.sql
inherit.sql
init_privs.sql
insert_conflict.sql
join_hash.sql
json.sql
json_encoding.sql
jsonb.sql
jsonb_jsonpath.sql
jsonpath.sql
jsonpath_encoding.sql
line.sql
lock.sql
lseg.sql
macaddr.sql
macaddr8.sql
matview.sql
misc_functions.sql
misc_sanity.sql
money.sql
name.sql
namespace.sql
numeric_big.sql
numerology.sql
object_address.sql
oid.sql
oidjoins.sql
opr_sanity.sql
partition_aggregate.sql
partition_info.sql
partition_join.sql
partition_prune.sql
password.sql
path.sql
pg_lsn.sql
pg_regress.list
plancache.sql
plpgsql.sql
point.sql
polygon.sql
polymorphism.sql
portals.sql
portals_p2.sql
prepare.sql
prepared_xacts.sql
privileges.sql
psql.sql
psql_crosstab.sql
publication.sql
random.sql
rangefuncs.sql
rangetypes.sql
regex.linux.utf8.sql
regex.sql
regproc.sql
reindex_catalog.sql
reloptions.sql
replica_identity.sql
returning.sql
roleattributes.sql
rowsecurity.sql
rowtypes.sql
rules.sql
sanity_check.sql
security_label.sql
select_distinct_on.sql
select_into.sql
select_parallel.sql
select_views.sql
sequence.sql
spgist.sql
stats.sql
stats_ext.sql
subscription.sql
subselect.sql
sysviews.sql
tablesample.sql
temp.sql
tidscan.sql
time.sql
timestamptz.sql
timetz.sql
transactions.sql
triggers.sql
truncate.sql
tsdicts.sql
tsearch.sql
tsrf.sql
tstypes.sql
txid.sql
type_sanity.sql
typed_table.sql
updatable_views.sql
update.sql
uuid.sql
vacuum.sql
varchar.sql
write_parallel.sql
xml.sql
xmlmap.sql
{code}
 

> Port test cases from PostgreSQL to Spark SQL
> --------------------------------------------
>
>                 Key: SPARK-27763
>                 URL: https://issues.apache.org/jira/browse/SPARK-27763
>             Project: Spark
>          Issue Type: Umbrella
>          Components: SQL
>    Affects Versions: 3.0.0
>            Reporter: Xiao Li
>            Assignee: Yuming Wang
>            Priority: Major
>
> To improve the test coverage, we can port the regression tests from the other popular open source projects to Spark SQL. PostgreSQL is one of the best SQL systems. Below are the links to the test cases and results. 
>  * Regression test cases: [https://github.com/postgres/postgres/tree/master/src/test/regress/sql]
>  * Expected results: [https://github.com/postgres/postgres/tree/master/src/test/regress/expected]
> Spark SQL does not support all the feature sets of PostgreSQL. In the current stage, we should first comment out these test cases and create the corresponding JIRAs in SPARK-27764. We can discuss and prioritize which features we should support. Also, these PostgreSQL regression tests could also expose the existing bugs of Spark SQL. We should also create the JIRAs and track them in SPARK-27764. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org