[jira] Commented: (SOLR-935) DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662772#action_12662772 ] 

Shalin Shekhar Mangar commented on SOLR-935:
--------------------------------------------

We can add this piece of logging but what benefit will that provide? Will it scare users when they see something like "Mutex Acquisition failure" in the logs?

> DataImportHandler: Add logging to record failure to acquire lock by DataImporter for a given request 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-935
>                 URL: https://issues.apache.org/jira/browse/SOLR-935
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>         Environment: Java 6, Tomcat 6.0.18
>            Reporter: Kay Kay
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-935.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a possibility of 2 threads to be in DataImporter:runCmd, until before  importLock.tryLock() method and then depending on the scheduling - one of them is allowed to pass through from then .
> We need to log the failure of the other as to unable to start because of the failure to acquire the mutex, to distinguish between successful start of import and failure to do so. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.