You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by jdasch <gi...@git.apache.org> on 2018/02/14 15:31:39 UTC
[GitHub] incubator-rya pull request #274: Added giraph profile to resolve an incompat...
GitHub user jdasch opened a pull request:
https://github.com/apache/incubator-rya/pull/274
Added giraph profile to resolve an incompatible license issue.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Description
Added a profile to make rya.giraph an optional module in the maven build.
### Tests
N/A
### Checklist
- [ ] Code Review
- [ ] Squash Commits
#### People To Review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdasch/incubator-rya candidate/giraph-profile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #274
----
commit 5cdfae209d176585b40b7cedede4808ee5de9a22
Author: jdasch <hc...@...>
Date: 2018-02-13T21:49:10Z
Added giraph profile to resolve an incompatible license issue.
----
---
[GitHub] incubator-rya issue #274: Added giraph profile to resolve an incompatible li...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/274
Good idea. I just pinged their dev list.
---
[GitHub] incubator-rya issue #274: Added giraph profile to resolve an incompatible li...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/incubator-rya/pull/274
Hrm, maybe worth it to send a note to the Giraph mailing lists? If this really is an LGPL dependency, then Apache Giraph shouldn't be depending on it either.
---
[GitHub] incubator-rya issue #274: Added giraph profile to resolve an incompatible li...
Posted by adinancr <gi...@git.apache.org>.
Github user adinancr commented on the issue:
https://github.com/apache/incubator-rya/pull/274
I'll merge this so we can release Rya. When/if Giraph fixes their code to remove the LGPL dependency, we can remove the optional part of the Rya- Giraph module
---
[GitHub] incubator-rya issue #274: Added giraph profile to resolve an incompatible li...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/274
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/690/
---
[GitHub] incubator-rya pull request #274: Added giraph profile to resolve an incompat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/274
---