[GitHub] [shardingsphere] wgy8283335 commented on a diff in pull request #23703: Replace filterable with translatable, and add supoort for date …

["wgy8283335 (via GitHub)" <gi...@apache.org>]

wgy8283335 commented on code in PR #23703:
URL: https://github.com/apache/shardingsphere/pull/23703#discussion_r1133363980


##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/decider/engine/SQLFederationDeciderEngine.java:
##########
@@ -62,6 +62,9 @@ public SQLFederationDeciderContext decide(final QueryContext queryContext, final
         SQLFederationDeciderContext result = new SQLFederationDeciderContext();
         SQLStatementContext<?> sqlStatementContext = queryContext.getSqlStatementContext();
         // TODO move this logic to SQLFederationDecider implement class when we remove sqlFederationEnabled
+        if (queryContext.getSql().contains("WHEN")) {

Review Comment:
   The "WHEN" is not supported by the federation query.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org