You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/13 06:37:07 UTC

[GitHub] [incubator-kyuubi] jiaoqingbo opened a new issue, #2346: [Improvement] Simplify FlinkProcessBuilder with java executable

jiaoqingbo opened a new issue, #2346:
URL: https://github.com/apache/incubator-kyuubi/issues/2346

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   Build the java command programlly instead of a static shell script. just like #2336 
   
   ### How should we improve?
   
   Build the java command programlly instead of a static shell script. just like #2336 
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2346: [Improvement] Simplify FlinkProcessBuilder with java executable

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #2346:
URL: https://github.com/apache/incubator-kyuubi/issues/2346#issuecomment-1098276420

   @jiaoqingbo, IMO, you'd better to understand the implementation of the `config.sh` firstly for the check whether to simplify the `FlinkProcessBuilder` with java executable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn closed issue #2346: [Improvement] Simplify FlinkProcessBuilder with java executable

Posted by GitBox <gi...@apache.org>.
yaooqinn closed issue #2346: [Improvement] Simplify FlinkProcessBuilder with java executable
URL: https://github.com/apache/incubator-kyuubi/issues/2346


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] deadwind4 commented on issue #2346: [Improvement] Simplify FlinkProcessBuilder with java executable

Posted by GitBox <gi...@apache.org>.
deadwind4 commented on issue #2346:
URL: https://github.com/apache/incubator-kyuubi/issues/2346#issuecomment-1097760300

   https://github.com/apache/incubator-kyuubi/blob/9e486080ffad43245c84cda9674196f15a226bd8/externals/kyuubi-flink-sql-engine/bin/flink-sql-engine.sh#L30


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] jiaoqingbo commented on issue #2346: [Improvement] Simplify FlinkProcessBuilder with java executable

Posted by GitBox <gi...@apache.org>.
jiaoqingbo commented on issue #2346:
URL: https://github.com/apache/incubator-kyuubi/issues/2346#issuecomment-1097781630

   > How do we resolve this line?
   > 
   > https://github.com/apache/incubator-kyuubi/blob/9e486080ffad43245c84cda9674196f15a226bd8/externals/kyuubi-flink-sql-engine/bin/flink-sql-engine.sh#L30
   
   I am also considering this problem, I need to look at the implementation logic of config.sh


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org