[GitHub] [cordova-android] dpogue commented on a change in pull request #893: feat: add google services support

[GitBox <gi...@apache.org>]

dpogue commented on a change in pull request #893: feat: add google services support
URL: https://github.com/apache/cordova-android/pull/893#discussion_r366718427
 
 

 ##########
 File path: bin/templates/project/app/build.gradle
 ##########
 @@ -356,3 +377,7 @@ for (def func : cdvPluginPostBuildExtras) {
 if (hasProperty('postBuildExtras')) {
     postBuildExtras()
 }
+
+if (cdvHelpers.getConfigPreference('GoogleServicesEnable', 'false').toBoolean()) {
+    apply plugin: 'com.google.gms.google-services'
 
 Review comment:
   In my plugin when I do this, for some reason it needs to be the full path to the plugin, not just the string... I think that might have had something to do with being a subproject though
   
   ```gradle
   apply plugin: com.google.gms.googleservices.GoogleServicesPlugin
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org