You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/12/04 01:57:56 UTC

[PR] [SPARK-46048][PYTHON][CONNECT][FOLLOWUP] Correct the string representation [spark]

zhengruifeng opened a new pull request, #44140:
URL: https://github.com/apache/spark/pull/44140

   ### What changes were proposed in this pull request?
   Correct the string representation
   
   
   ### Why are the changes needed?
   to fix a minor issue
   
   ### Does this PR introduce _any_ user-facing change?
   yes
   
   before:
   ```
   In [1]: spark.range(10).groupingSets([])
   Out[1]: GroupedData[grouping expressions: [], value: [id: bigint], type: Pivot]
   ```
   
   after:
   ```
   In [2]: spark.range(10).groupingSets([])
   Out[2]: GroupedData[grouping expressions: [], value: [id: bigint], type: GroupingSets]
   ```
   
   
   ### How was this patch tested?
   manually test, it is trivial so I don't add a doctest
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46048][PYTHON][CONNECT][FOLLOWUP] Correct the string representation [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44140:
URL: https://github.com/apache/spark/pull/44140#issuecomment-1837720246

   cc @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46048][PYTHON][CONNECT][FOLLOWUP] Correct the string representation [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44140:
URL: https://github.com/apache/spark/pull/44140#issuecomment-1837722763

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46048][PYTHON][CONNECT][FOLLOWUP] Correct the string representation [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44140: [SPARK-46048][PYTHON][CONNECT][FOLLOWUP] Correct the string representation
URL: https://github.com/apache/spark/pull/44140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org