You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tomcat.apache.org by Adam Rauch <ad...@labkey.com> on 2019/01/02 19:50:42 UTC

JspC ignores uriroot property as of Tomcat 9.0.14 / 8.5.37

Our build pre-compiles JSPs by invoking JspC following a pattern similar 
to the JspC JavaDoc example configuration: 
https://tomcat.apache.org/tomcat-8.5-doc/api/org/apache/jasper/JspC.html

Starting with 9.0.14 and 8.5.37, our build stopped pre-compiling JSPs; 
JspC no longer converts a tree of *.jsp files into a tree of *_jsp.java 
files. Reviewing the change list, it looks like "53737: Extend JspC, the 
precompilation tool, to include support for resource JARs. (markt)" is 
related. Commit 1846928 no longer respects the "uriroot" property (in 
the pages.size() == 0 case):

svn diff -r 1846928 
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_14/java/org/apache/jasper/JspC.java

Please let me know if I should open bugzilla issue or if this is an 
intentional change in behavior.

Thanks,
Adam


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Re: JspC ignores uriroot property as of Tomcat 9.0.14 / 8.5.37

Posted by Mark Thomas <ma...@apache.org>.
On 04/01/2019 03:08, Adam Rauch wrote:
> On 1/3/2019 11:53 AM, Mark Thomas wrote:
>> On 02/01/2019 19:50, Adam Rauch wrote:
>>> Our build pre-compiles JSPs by invoking JspC following a pattern similar
>>> to the JspC JavaDoc example configuration:
>>> https://tomcat.apache.org/tomcat-8.5-doc/api/org/apache/jasper/JspC.html
>>>
>>> Starting with 9.0.14 and 8.5.37, our build stopped pre-compiling JSPs;
>>> JspC no longer converts a tree of *.jsp files into a tree of *_jsp.java
>>> files. Reviewing the change list, it looks like "53737: Extend JspC, the
>>> precompilation tool, to include support for resource JARs. (markt)" is
>>> related. Commit 1846928 no longer respects the "uriroot" property (in
>>> the pages.size() == 0 case):
>>>
>>> svn diff -r 1846928
>>> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_14/java/org/apache/jasper/JspC.java
>>>
>>>
>>>
>>> Please let me know if I should open bugzilla issue or if this is an
>>> intentional change in behavior.
>> That sounds like a bug. If you open a BZ issue and provide the simplest
>> possible example (i.e. zipped up build dir with a single JSP and the
>> appropriate Ant file or command line to call JspC) then I'll take a look.
>>
>> Mark
> 
> Bugzilla opened: https://bz.apache.org/bugzilla/show_bug.cgi?id=63056

Definitely a bug. Definitely my fault. Sorry. It will be fixed in the
next release.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Re: Re: JspC ignores uriroot property as of Tomcat 9.0.14 / 8.5.37

Posted by Adam Rauch <ad...@labkey.com>.
On 1/3/2019 11:53 AM, Mark Thomas wrote:
> On 02/01/2019 19:50, Adam Rauch wrote:
>> Our build pre-compiles JSPs by invoking JspC following a pattern similar
>> to the JspC JavaDoc example configuration:
>> https://tomcat.apache.org/tomcat-8.5-doc/api/org/apache/jasper/JspC.html
>>
>> Starting with 9.0.14 and 8.5.37, our build stopped pre-compiling JSPs;
>> JspC no longer converts a tree of *.jsp files into a tree of *_jsp.java
>> files. Reviewing the change list, it looks like "53737: Extend JspC, the
>> precompilation tool, to include support for resource JARs. (markt)" is
>> related. Commit 1846928 no longer respects the "uriroot" property (in
>> the pages.size() == 0 case):
>>
>> svn diff -r 1846928
>> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_14/java/org/apache/jasper/JspC.java
>>
>>
>> Please let me know if I should open bugzilla issue or if this is an
>> intentional change in behavior.
> That sounds like a bug. If you open a BZ issue and provide the simplest
> possible example (i.e. zipped up build dir with a single JSP and the
> appropriate Ant file or command line to call JspC) then I'll take a look.
>
> Mark

Bugzilla opened: https://bz.apache.org/bugzilla/show_bug.cgi?id=63056

Adam


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Re: JspC ignores uriroot property as of Tomcat 9.0.14 / 8.5.37

Posted by Mark Thomas <ma...@apache.org>.
On 02/01/2019 19:50, Adam Rauch wrote:
> Our build pre-compiles JSPs by invoking JspC following a pattern similar
> to the JspC JavaDoc example configuration:
> https://tomcat.apache.org/tomcat-8.5-doc/api/org/apache/jasper/JspC.html
> 
> Starting with 9.0.14 and 8.5.37, our build stopped pre-compiling JSPs;
> JspC no longer converts a tree of *.jsp files into a tree of *_jsp.java
> files. Reviewing the change list, it looks like "53737: Extend JspC, the
> precompilation tool, to include support for resource JARs. (markt)" is
> related. Commit 1846928 no longer respects the "uriroot" property (in
> the pages.size() == 0 case):
> 
> svn diff -r 1846928
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_14/java/org/apache/jasper/JspC.java
> 
> 
> Please let me know if I should open bugzilla issue or if this is an
> intentional change in behavior.

That sounds like a bug. If you open a BZ issue and provide the simplest
possible example (i.e. zipped up build dir with a single JSP and the
appropriate Ant file or command line to call JspC) then I'll take a look.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org