You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/07 06:38:22 UTC
[GitHub] [skywalking-java] xiaoxiongmao-liu opened a new pull request #43: feature: support xxl-job version 2.3.0
xiaoxiongmao-liu opened a new pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937517733
> You need to add test to that version. Also, in the new version if the argument is removed, how to get the job name?
Actually,I have test to 2.3.0 and 2.2.0. The removed argument is 'JobParam',not the job name and just as a tag, useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng removed a comment on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng removed a comment on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937519842
> > You need to add test to that version. Also, in the new version if the argument is removed, how to get the job name?
>
>
>
> Actually,I have test to 2.3.0 and 2.2.0. The removed argument is 'JobParam',not the job name and just as a tag, useless.
Why job param useless? Even though, I am not using java agent or this plugin, I feel this parameter matters about how this job gets triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r730408898
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -25,4 +25,9 @@
<allow pkg="java"/>
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
+
+ <subpackage name="xxljob" >
+ <allow pkg="com.xxl.job.core.context"/>
+ </subpackage>
</import-control>
+
Review comment:
That is the point, don't import anything related to your package in the instrumentation.
Because once you did, other people not using xxl-job but keep this plugin in the plugins lib, will face ClassNotFound exception. Always use String name, rather than anything like `xxx.class`.getName.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937519777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r738992105
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -26,3 +26,4 @@
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
</import-control>
+
Review comment:
Revert this in your next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r730409357
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -25,4 +25,9 @@
<allow pkg="java"/>
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
+
+ <subpackage name="xxljob" >
+ <allow pkg="com.xxl.job.core.context"/>
+ </subpackage>
</import-control>
+
Review comment:
Ok, I get it. I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-941807896
> @xiaoxiongmao-liu Are you still working on this?
Yes, I will do it as soon as possible.But I am busy my official work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng removed a comment on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng removed a comment on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937519842
> > You need to add test to that version. Also, in the new version if the argument is removed, how to get the job name?
>
>
>
> Actually,I have test to 2.3.0 and 2.2.0. The removed argument is 'JobParam',not the job name and just as a tag, useless.
Why job param useless? Even though, I am not using java agent or this plugin, I feel this parameter matters about how this job gets triggered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937517733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r730406463
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -25,4 +25,9 @@
<allow pkg="java"/>
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
+
+ <subpackage name="xxljob" >
+ <allow pkg="com.xxl.job.core.context"/>
+ </subpackage>
</import-control>
+
Review comment:
Please don't change this. We set up this rule on purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-941806238
@xiaoxiongmao-liu Are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r738983789
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -25,4 +25,9 @@
<allow pkg="java"/>
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
+
+ <subpackage name="xxljob" >
+ <allow pkg="com.xxl.job.core.context"/>
+ </subpackage>
</import-control>
+
Review comment:
OK，I will finish them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r730408689
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -25,4 +25,9 @@
<allow pkg="java"/>
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
+
+ <subpackage name="xxljob" >
+ <allow pkg="com.xxl.job.core.context"/>
+ </subpackage>
</import-control>
+
Review comment:
I just allow this package to be imported in xxljob's package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r738966964
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -25,4 +25,9 @@
<allow pkg="java"/>
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
+
+ <subpackage name="xxljob" >
+ <allow pkg="com.xxl.job.core.context"/>
+ </subpackage>
</import-control>
+
Review comment:
We are still waiting for you to enhance the plugin tests. Please finish them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r738992621
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -26,3 +26,4 @@
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
</import-control>
+
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937524452
> > > You need to add test to that version. Also, in the new version if the argument is removed, how to get the job name?
> >
> >
> > Actually,I have test to 2.3.0 and 2.2.0. The removed argument is 'JobParam',not the job name and just as a tag, useless.
>
> Why job param useless? Even though, I am not using java agent or this plugin, I feel this parameter matters about how this job gets triggered.
version 2.3.0 change the method "excuate" signature. And you can get the job param by the method "XxlJobHelper.getJobParam();"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r730408041
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -25,4 +25,9 @@
<allow pkg="java"/>
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
+
+ <subpackage name="xxljob" >
+ <allow pkg="com.xxl.job.core.context"/>
+ </subpackage>
</import-control>
+
Review comment:
Your plugin has nothing new comparing to the other plugins. This rule makes sure that, you don't import unexpected things in instrumentation definition.
Please read error log carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937529122
> Then this is typical case you should use witness class or method to identify versions, then use different interceptor and instructions for different versions. Then the core could choose the right plugin in the runtime.
Actually, according to "allArguments.length" can identify version,2.2.0 work as before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-941807896
> @xiaoxiongmao-liu Are you still working on this?
Yes, I will do it as soon as possible.But I am busy my official work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937537838
Then, you should fill the logic for 2.3.0 too. Let's keep them consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937525777
Then this is typical case you should use witness class or method to identify versions, then use different interceptor and instructions for different versions.
Then the core could choose the right plugin in the runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-941806238
@xiaoxiongmao-liu Are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng closed pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937753739
> Then, you should fill the logic for 2.3.0 too. Let's keep them consistent
OK, I will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#issuecomment-937519777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaoxiongmao-liu commented on a change in pull request #43: feature: support xxl-job version 2.3.0
Posted by GitBox <gi...@apache.org>.
xiaoxiongmao-liu commented on a change in pull request #43:
URL: https://github.com/apache/skywalking-java/pull/43#discussion_r730407812
##########
File path: apm-checkstyle/importControl.xml
##########
@@ -25,4 +25,9 @@
<allow pkg="java"/>
<allow pkg="org.apache.skywalking"/>
<allow pkg="net.bytebuddy"/>
+
+ <subpackage name="xxljob" >
+ <allow pkg="com.xxl.job.core.context"/>
+ </subpackage>
</import-control>
+
Review comment:
This package is necessary to add tag "jobParam" for version 2.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org