You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/26 20:30:27 UTC
[GitHub] [tvm] mehrdadh opened a new pull request, #11476: [Hexagon] Download generated artifacts from android device to host
mehrdadh opened a new pull request, #11476:
URL: https://github.com/apache/tvm/pull/11476
waiting for https://github.com/apache/tvm/pull/11362 to merge.
cc @csullivan @farshidsp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] supersat commented on a diff in pull request #11476: [Hexagon] Download generated artifacts from android device to host
Posted by GitBox <gi...@apache.org>.
supersat commented on code in PR #11476:
URL: https://github.com/apache/tvm/pull/11476#discussion_r883096664
##########
python/tvm/contrib/hexagon/build.py:
##########
@@ -472,6 +477,15 @@ def _cleanup_directory(self):
# Remove workspace directory on remote target
subprocess.Popen(self._adb_device_sub_cmd + ["shell", f"rm -rf {self._workspace}"])
+ def _copy_artifacts_to_host(self):
+ # Copy generated artifacts from device to host
+ if self._host_workspace:
+ for file in ["tvm_rpc_android.farf", "tvm_rpc_android.log"]:
Review Comment:
If the intention is to pull of the debug output from Hexagon, you'll likely need to run logcat in parallel, possibly filtering out extraneous messages from the rest of the system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh closed pull request #11476: [Hexagon] Download generated artifacts from android device to host
Posted by GitBox <gi...@apache.org>.
mehrdadh closed pull request #11476: [Hexagon] Download generated artifacts from android device to host
URL: https://github.com/apache/tvm/pull/11476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] supersat commented on a diff in pull request #11476: [Hexagon] Download generated artifacts from android device to host
Posted by GitBox <gi...@apache.org>.
supersat commented on code in PR #11476:
URL: https://github.com/apache/tvm/pull/11476#discussion_r883090373
##########
python/tvm/contrib/hexagon/build.py:
##########
@@ -472,6 +477,15 @@ def _cleanup_directory(self):
# Remove workspace directory on remote target
subprocess.Popen(self._adb_device_sub_cmd + ["shell", f"rm -rf {self._workspace}"])
+ def _copy_artifacts_to_host(self):
+ # Copy generated artifacts from device to host
+ if self._host_workspace:
+ for file in ["tvm_rpc_android.farf", "tvm_rpc_android.log"]:
Review Comment:
The farf file only configures fastrpc to forward Hexagon logs to Android's logging facility. There's no need to pull it back off the device.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org