You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Szabolcs Vasas <va...@gmail.com> on 2018/01/08 15:15:44 UTC
Review Request 65020: HBase test cases should start mini DFS cluster
as well
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65020/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-3275
https://issues.apache.org/jira/browse/SQOOP-3275
Repository: sqoop-trunk
Description
-------
HBaseTestCase.setUp() now calls org.apache.hadoop.hbase.HBaseTestingUtility#startMiniCluster() method to start up HBase, Zookeeper and HDFS mini clusters.
Since HDFS mini cluster is started we need to set extra Kerberos-related properties in the setupKerberos() method.
Diffs
-----
ivy.xml 86de94f6440604ccbbd5192599a5fadb8796f7a9
src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java cf42d317a339360e0242dc030dc2d732896c9b32
Diff: https://reviews.apache.org/r/65020/diff/1/
Testing
-------
Executed unit and third party tests.
Thanks,
Szabolcs Vasas
Re: Review Request 65020: HBase test cases should start mini DFS
cluster as well
Posted by Szabolcs Vasas <va...@gmail.com>.
> On Jan. 8, 2018, 3:22 p.m., Fero Szabo wrote:
> > src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java
> > Lines 81 (patched)
> > <https://reviews.apache.org/r/65020/diff/1/?file=1935495#file1935495line83>
> >
> > Just out of curiosity, what does port "0" mean / do here? Is this a setting that is practically never used, but needed?
This configuration parameter will be used in org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager#DatanodeManager, 0 basically means that the system will pick up an ephemeral port for creating the socket (see: org.apache.hadoop.net.NetUtils#createSocketAddrForHost)
- Szabolcs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65020/#review194949
-----------------------------------------------------------
On Jan. 8, 2018, 3:15 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65020/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2018, 3:15 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3275
> https://issues.apache.org/jira/browse/SQOOP-3275
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> HBaseTestCase.setUp() now calls org.apache.hadoop.hbase.HBaseTestingUtility#startMiniCluster() method to start up HBase, Zookeeper and HDFS mini clusters.
> Since HDFS mini cluster is started we need to set extra Kerberos-related properties in the setupKerberos() method.
>
>
> Diffs
> -----
>
> ivy.xml 86de94f6440604ccbbd5192599a5fadb8796f7a9
> src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java cf42d317a339360e0242dc030dc2d732896c9b32
>
>
> Diff: https://reviews.apache.org/r/65020/diff/1/
>
>
> Testing
> -------
>
> Executed unit and third party tests.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>
Re: Review Request 65020: HBase test cases should start mini DFS
cluster as well
Posted by Fero Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65020/#review194949
-----------------------------------------------------------
Ship it!
src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java
Lines 81 (patched)
<https://reviews.apache.org/r/65020/#comment274051>
Just out of curiosity, what does port "0" mean / do here? Is this a setting that is practically never used, but needed?
- Fero Szabo
On Jan. 8, 2018, 3:15 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65020/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2018, 3:15 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3275
> https://issues.apache.org/jira/browse/SQOOP-3275
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> HBaseTestCase.setUp() now calls org.apache.hadoop.hbase.HBaseTestingUtility#startMiniCluster() method to start up HBase, Zookeeper and HDFS mini clusters.
> Since HDFS mini cluster is started we need to set extra Kerberos-related properties in the setupKerberos() method.
>
>
> Diffs
> -----
>
> ivy.xml 86de94f6440604ccbbd5192599a5fadb8796f7a9
> src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java cf42d317a339360e0242dc030dc2d732896c9b32
>
>
> Diff: https://reviews.apache.org/r/65020/diff/1/
>
>
> Testing
> -------
>
> Executed unit and third party tests.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>
Re: Review Request 65020: HBase test cases should start mini DFS
cluster as well
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65020/#review194960
-----------------------------------------------------------
Ship it!
Hi Szabi,
Nice catch! All tests are passing with your patch.
Thanks,
Bogi
- Boglarka Egyed
On Jan. 8, 2018, 3:15 p.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65020/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2018, 3:15 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3275
> https://issues.apache.org/jira/browse/SQOOP-3275
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> HBaseTestCase.setUp() now calls org.apache.hadoop.hbase.HBaseTestingUtility#startMiniCluster() method to start up HBase, Zookeeper and HDFS mini clusters.
> Since HDFS mini cluster is started we need to set extra Kerberos-related properties in the setupKerberos() method.
>
>
> Diffs
> -----
>
> ivy.xml 86de94f6440604ccbbd5192599a5fadb8796f7a9
> src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java cf42d317a339360e0242dc030dc2d732896c9b32
>
>
> Diff: https://reviews.apache.org/r/65020/diff/1/
>
>
> Testing
> -------
>
> Executed unit and third party tests.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>