You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/06/02 07:06:42 UTC
[GitHub] [camel] zhfeng opened a new pull request #3880: CAMEL-14805: Component - Use doInit for wiring instead of doStart
zhfeng opened a new pull request #3880:
URL: https://github.com/apache/camel/pull/3880
* camel-hbase
* camel-jing
* camel-jpa
* camel-msv
* camel-pulsar
* camel-snmp
* camel-spark
* camel-stax
* camel-undertow
* camel-xmlsecurity
* camel-xslt-saxon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #3880: CAMEL-14805: Component - Use doInit for wiring instead of doStart
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #3880:
URL: https://github.com/apache/camel/pull/3880
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet commented on a change in pull request #3880: CAMEL-14805: Component - Use doInit for wiring instead of doStart
Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #3880:
URL: https://github.com/apache/camel/pull/3880#discussion_r433668555
##########
File path: components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpEndpoint.java
##########
@@ -265,8 +265,8 @@ public void setProtocol(String protocol) {
}
@Override
- protected void doStart() throws Exception {
- super.doStart();
+ protected void doInit() throws Exception {
+ super.doInit();
URI uri = URI.create(getEndpointUri());
Review comment:
No, there is no network access when creating a `URI` afaik.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #3880: CAMEL-14805: Component - Use doInit for wiring instead of doStart
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #3880:
URL: https://github.com/apache/camel/pull/3880#discussion_r433668958
##########
File path: components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpEndpoint.java
##########
@@ -265,8 +265,8 @@ public void setProtocol(String protocol) {
}
@Override
- protected void doStart() throws Exception {
- super.doStart();
+ protected void doInit() throws Exception {
+ super.doInit();
URI uri = URI.create(getEndpointUri());
Review comment:
I don't think so
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #3880: CAMEL-14805: Component - Use doInit for wiring instead of doStart
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #3880:
URL: https://github.com/apache/camel/pull/3880#discussion_r433671698
##########
File path: components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpEndpoint.java
##########
@@ -265,8 +265,8 @@ public void setProtocol(String protocol) {
}
@Override
- protected void doStart() throws Exception {
- super.doStart();
+ protected void doInit() throws Exception {
+ super.doInit();
URI uri = URI.create(getEndpointUri());
Review comment:
Ah thanks yeah I found the answer too in the javadocs, URI mentions further below that URL on contrast does IO networking: https://docs.oracle.com/javase/7/docs/api/java/net/URI.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #3880: CAMEL-14805: Component - Use doInit for wiring instead of doStart
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #3880:
URL: https://github.com/apache/camel/pull/3880#discussion_r433666547
##########
File path: components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpEndpoint.java
##########
@@ -265,8 +265,8 @@ public void setProtocol(String protocol) {
}
@Override
- protected void doStart() throws Exception {
- super.doStart();
+ protected void doInit() throws Exception {
+ super.doInit();
URI uri = URI.create(getEndpointUri());
Review comment:
Oh there may be a problem when creating an URI as its a network resource. And its either URL or URI in Java that does some networking thingy when being created. @gnodet @ppalaga @lburgazzoli @oscerd @jamesnetherton ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org