[jira] [Comment Edited] (SUREFIRE-1681) Don't ignore errors while using maven.test.failure.ignore

["Tibor Digana (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498445#comment-17498445 ] 

Tibor Digana edited comment on SUREFIRE-1681 at 2/26/22, 1:28 PM:
------------------------------------------------------------------

[~olamy]
Read the description, this is not related to your problem in ASF.
The user here wants to say that he wants to print the a message on the console if {{maven.test.failure.ignore}} is set.
Your problem is that you run JPMS on JDK8 and you want to compromise the behavior of {{maven.test.failure.ignore}} and you want to make an exception so that the build would fail if you use JVM parameter which is unknown for the VM. This is questionary and can be discussed because always here can be two parties of people who may agree with you and who may disagree because the behavior of {{maven.test.failure.ignore}} would not be so strick as so far. Some people may see different behavior on {{maven.test.failure.ignore}} if using {{forkCount=0}} for in-plugin execution and other when {{forkCount > 0}} and finally the resulting behavior would be different. Some people may say that Maven has very similar option {{fail-never}} and the natural question rises up, should we have strictly NOT to fail the build on illegal {{argLine}} or should strictly fail the build? Another plugin Maven Compiler is also using forked JVM to compile sources and there the VM may fail which is similar situation to yours and the behavior should be similar.


was (Author: tibor17):
[~olamy]
Read the description, this is not related to your problem in ASF.
The user here wants to say that he wants to print the a message on the console if {{maven.test.failure.ignore}} is set.
Your problem is that you run JPMS on JDK8 and you want to compromise the behavior of {{maven.test.failure.ignore}} and you want to make an exception so that the build would fail if you use JVM parameter which is unknown for the VM. This is questionary and can be discussed because always here can be two parties of people who may agree with you and who may disagree because the behavior of {{maven.test.failure.ignore}} would not be so strick as so far. Some people may see different behavior on {{maven.test.failure.ignore}} if using {{forkCount=0}} for in-plugin execution and other when {{forkCount > 0}} and finally the resulting behavior would be different. Some people may say that Maven has very similar option {{fail-never}} and the natural question rises up, should we have strictly NOT to fail the build on illegal {{argLine}} or should strictly fail the build? Another plubin Maven Compiler is also using forked JVM to compile sources and there the VM may fail which is similar situation to yours and the behavior should be similar.

> Don't ignore errors while using maven.test.failure.ignore
> ---------------------------------------------------------
>
>                 Key: SUREFIRE-1681
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1681
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Maven Surefire Plugin
>    Affects Versions: 3.0.0-M3
>            Reporter: Josef Cacek
>            Assignee: Tibor Digana
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is a follow up for SUREFIRE-1426.
> Surefire should only ignore test failures when SurefirePlugin.testFailureIgnore property is set to true (as the name suggests). Test errors should not be ignored.
> If the forked JVM crashes during the test, then TEST-*.xml report file is not created, so the user will miss the problem when he evaluates test reports afterward (e.g. in Jenkins).
> The code of SurefireHelper.report execution could be improved to verify the error count:
> {code:java}
> if ( reportParameters.isTestFailureIgnore() && result.getErrors() == 0 )
> {
>     log.error( createErrorMessage( reportParameters, result, firstForkException ) );
> }
> {code}
> instead of simply ignoring all problems as it's now:
> {code:java}
> if ( reportParameters.isTestFailureIgnore() )
> {
>     log.error( createErrorMessage( reportParameters, result, firstForkException ) );
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)