You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2024/11/28 12:30:52 UTC
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22140
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
IMPALA-13588: Update Puffin reading doc after IMPALA-13370
IMPALA-13370 added support for reading Puffin NDV stats from the
metadata.json if the "NDV" property is available. This change updates
the docs accordingly.
Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
---
M docs/topics/impala_iceberg.xml
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/22140/2
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22140 )
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/814/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2024 10:53:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22140 )
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/813/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Nov 2024 12:31:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22140 )
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22140/2/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/22140/2/docs/topics/impala_iceberg.xml@884
PS2, Line 884: skip reading
: the corresponding value from
nit: "read the value from the metadata.json instead of"
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Nov 2024 13:44:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22140 )
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
IMPALA-13588: Update Puffin reading doc after IMPALA-13370
IMPALA-13370 added support for reading Puffin NDV stats from the
metadata.json if the "NDV" property is available. This change updates
the docs accordingly.
Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Reviewed-on: http://gerrit.cloudera.org:8080/22140
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Noemi Pap-Takacs <np...@cloudera.com>
Reviewed-by: Peter Rozsa <pr...@cloudera.com>
---
M docs/topics/impala_iceberg.xml
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Noemi Pap-Takacs: Looks good to me, but someone else must approve
Peter Rozsa: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22140 )
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Dec 2024 13:56:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/22140 )
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
IMPALA-13588: Update Puffin reading doc after IMPALA-13370
IMPALA-13370 added support for reading Puffin NDV stats from the
metadata.json if the "NDV" property is available. This change updates
the docs accordingly.
Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
---
M docs/topics/impala_iceberg.xml
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/22140/3
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22140 )
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/814/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2024 10:46:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22140 )
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Dec 2024 12:31:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13588: Update Puffin reading doc after IMPALA-13370
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22140 )
Change subject: IMPALA-13588: Update Puffin reading doc after IMPALA-13370
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/813/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/22140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f5454d736ffb3a2c043f9b490c62976ccd0c2a
Gerrit-Change-Number: 22140
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Nov 2024 12:38:11 +0000
Gerrit-HasComments: No