You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/08/08 10:58:47 UTC
[GitHub] [ignite-3] valepakh opened a new pull request, #984: IGNITE-17110 Auto-connect on the REPL start
valepakh opened a new pull request, #984:
URL: https://github.com/apache/ignite-3/pull/984
https://issues.apache.org/jira/browse/IGNITE-17110
When user enters a REPL mode, ask if he wants to connect to the either last connected URL or to the default URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] asfgit closed pull request #984: IGNITE-17110 Auto-connect on the REPL start
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #984: IGNITE-17110 Auto-connect on the REPL start
URL: https://github.com/apache/ignite-3/pull/984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] kgusakov commented on a diff in pull request #984: IGNITE-17110 Auto-connect on the REPL start
Posted by GitBox <gi...@apache.org>.
kgusakov commented on code in PR #984:
URL: https://github.com/apache/ignite-3/pull/984#discussion_r943514097
##########
modules/cli/src/main/java/org/apache/ignite/cli/config/Profile.java:
##########
@@ -25,15 +25,25 @@
public interface Profile {
Review Comment:
Please, add javadocs for methods
##########
modules/cli/src/main/java/org/apache/ignite/cli/config/StateConfig.java:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.cli.config;
+
+import java.io.File;
+import java.io.IOException;
+import org.apache.ignite.cli.config.ini.IniConfig;
+import org.apache.ignite.cli.config.ini.IniFile;
+
+/**
+ * Config file which stores information between application restarts, but not part of the config.
+ */
+public class StateConfig {
+
+ /**
+ * Returns an instance of {@link Config} holding the properties.
+ *
+ * @param file INI file.
+ * @return new instance of {@link Config}
+ */
+
Review Comment:
```suggestion
```
##########
modules/cli/src/main/java/org/apache/ignite/cli/config/ini/IniConfig.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.cli.config.ini;
+
+import java.util.Map;
+import org.apache.ignite.cli.config.Config;
+
+/**
+ * Implementation of {@link Config} based on {@link IniSection}.
+ */
+public class IniConfig implements Config {
+ private final IniSection section;
+ private final Runnable saveAction;
+
+ public IniConfig(IniSection section, Runnable saveAction) {
+ this.section = section;
+ this.saveAction = saveAction;
+ }
+
+ @Override
Review Comment:
Annotate methods with `@inheritDoc`, pls
##########
modules/cli/src/main/java/org/apache/ignite/cli/config/ini/IniProfile.java:
##########
@@ -38,35 +38,7 @@ public String getName() {
}
@Override
Review Comment:
```suggestion
/** {@inheritDoc} */
@Override
```
##########
modules/cli/src/main/java/org/apache/ignite/cli/config/StateConfigProvider.java:
##########
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.cli.config;
+
+/**
+ * Provider for the application state config.
+ */
+public interface StateConfigProvider {
+ Config get();
Review Comment:
javadoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org