You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/05 12:22:31 UTC
[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull
request #5056: replace getTables() with getSimpleTableSegments()
tristaZero commented on a change in pull request #5056: replace getTables() with getSimpleTableSegments()
URL: https://github.com/apache/incubator-shardingsphere/pull/5056#discussion_r403694404
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/segment/impl/table/ExpectedTableFactor.java
##########
@@ -39,6 +41,9 @@
@XmlElement
private ExpectedSubquery subquery;
+ @XmlElement
+ private List<ExpectedColumn> columns;
Review comment:
You had better add at least one SQL case for `columns`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services