You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "moonchen (via GitHub)" <gi...@apache.org> on 2025/10/20 15:21:28 UTC
[PR] Use single regex match for Diags tags [trafficserver]
moonchen opened a new pull request, #12586:
URL: https://github.com/apache/trafficserver/pull/12586
Even though we sometimes activate multiple debug tags for Diag, we still only use a single regex to achieve this purpose. DFA is for matching multiple regexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use single regex match for Diags tags [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #12586:
URL: https://github.com/apache/trafficserver/pull/12586#discussion_r2445651372
##########
src/tscore/Diags.cc:
##########
@@ -362,7 +362,7 @@ Diags::activate_taglist(const char *taglist, DiagsTagType mode)
if (activated_tags[mode]) {
delete activated_tags[mode];
}
- activated_tags[mode] = new DFA;
+ activated_tags[mode] = new Regex;
Review Comment:
This might show up as a memory leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use single regex match for Diags tags [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #12586:
URL: https://github.com/apache/trafficserver/pull/12586#discussion_r2445651372
##########
src/tscore/Diags.cc:
##########
@@ -362,7 +362,7 @@ Diags::activate_taglist(const char *taglist, DiagsTagType mode)
if (activated_tags[mode]) {
delete activated_tags[mode];
}
- activated_tags[mode] = new DFA;
+ activated_tags[mode] = new Regex;
Review Comment:
This might show up as a memory leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use single regex match for Diags tags [trafficserver]
Posted by "moonchen (via GitHub)" <gi...@apache.org>.
moonchen merged PR #12586:
URL: https://github.com/apache/trafficserver/pull/12586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org