You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Heath Thomann (JIRA)" <ji...@apache.org> on 2010/09/29 22:12:32 UTC

[jira] Updated: (OPENJPA-712) Not correctly parsing the "having" clause with aggregate functions (ie. max, min, etc)

     [ https://issues.apache.org/jira/browse/OPENJPA-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Heath Thomann updated OPENJPA-712:
----------------------------------

    Attachment: OPENJPA-712-1.2.x.patch

I'm providing patch OPENJPA-712-1.2.x.patch which, as its name implies, is for 1.2.x and includes a 'backport' of OPENJPA-712.patch and OPENJPA-712-1.patch.  

Thanks,

Heath

> Not correctly parsing the "having" clause with aggregate functions (ie. max, min, etc)
> --------------------------------------------------------------------------------------
>
>                 Key: OPENJPA-712
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-712
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.2.1, 1.3.0
>         Environment: Configuration:
> - OpenJPA 1.2.0 / OpenJPA 1.3.0 SNAPSHOT
> - Enhancing at Build Time
> - MySQL 5.0.22
>            Reporter: Kevin Sutter
>            Assignee: Catalina Wei
>             Fix For: 1.3.0
>
>         Attachments: OPENJPA-712-1.2.x.patch, openjpa-712-1.patch, openjpa-712.patch
>
>
> Per the discussion on the dev forum (http://n2.nabble.com/Bug-in-HAVING-clause-(JPQL)-td835780.html)...  
> I found this easy to reproduce.  It seems that our jjpql parser is not properly processing the aggregate functions within the Having clause.
> It seems that these two (valid?) queries are throwing an exception:
>   select m.idPublisher, max(m.datePublished)
>     from Magazine m
>  group by m.idPublisher
>   having max(m.datePublished) is null
>   select m.idPublisher, max(m.datePublished)
>     from Magazine m
>  group by m.idPublisher
>   having max(m.datePublished) = current_date
> The exception thrown is:
> <openjpa-1.3.0-SNAPSHOT-runknown nonfatal user error> org.apache.openjpa.persistence.ArgumentException: Encountered "max ( m . datePublished ) is" at character 90, but expected: ["(", ")", "*", "+", "-", ".", "/", ":", "<", "<=", "<>", "=", ">", ">=", "?", "ABS", "ALL", "AND", "ANY", "AS", "ASC", "AVG", "BETWEEN", "BOTH", "BY", "CONCAT", "COUNT", "CURRENT_DATE", "CURRENT_TIME", "CURRENT_TIMESTAMP", "DELETE", "DESC", "DISTINCT", "EMPTY", "ESCAPE", "EXISTS", "FETCH", "FROM", "GROUP", "HAVING", "IN", "INNER", "IS", "JOIN", "LEADING", "LEFT", "LENGTH", "LIKE", "LOCATE", "LOWER", "MAX", "MEMBER", "MIN", "MOD", "NEW", "NOT", "NULL", "OBJECT", "OF", "OR", "ORDER", "OUTER", "SELECT", "SET", "SIZE", "SOME", "SQRT", "SUBSTRING", "SUM", "TRAILING", "TRIM", "UPDATE", "UPPER", "WHERE", <BOOLEAN_LITERAL>, <DECIMAL_LITERAL>, <IDENTIFIER>, <INTEGER_LITERAL>, <STRING_LITERAL>].
>        at org.apache.openjpa.kernel.jpql.JPQL.generateParseException(JPQL.java:9501)
>        at org.apache.openjpa.kernel.jpql.JPQL.jj_consume_token(JPQL.java:9378)
> ...
> For test case, one could use these classes:
> /openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/query/Magazine.java
> /openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/query/Publisher.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.