You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2023/12/11 14:35:58 UTC
[PR] Improve error message explaining why TestTls might fail [arrow]
jbonofre opened a new pull request, #39171:
URL: https://github.com/apache/arrow/pull/39171
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39170: [Java] Improve error message explaining why TestTls might fail [arrow]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #39171:
URL: https://github.com/apache/arrow/pull/39171#discussion_r1422594580
##########
java/flight/flight-core/src/test/java/org/apache/arrow/flight/FlightTestUtil.java:
##########
@@ -47,7 +48,11 @@ static Path exampleTlsRootCert() {
static List<CertKeyPair> exampleTlsCerts() {
final Path root = getFlightTestDataRoot();
- return Arrays.asList(new CertKeyPair(root.resolve("cert0.pem").toFile(), root.resolve("cert0.pkcs1").toFile()),
+ final Path cert0Pem = root.resolve("cert0.pem");
+ if (!Files.exists(cert0Pem)) {
+ throw new RuntimeException(cert0Pem + " doesn't exist. Take a look on https://arrow.apache.org/docs/dev/developers/java/building.html#building to initialize.");
Review Comment:
Good idea. Let me do the change. Thanks again !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve error message explaining why TestTls might fail [arrow]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #39171:
URL: https://github.com/apache/arrow/pull/39171#issuecomment-1850205872
This close #39170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39170: [Java] Improve error message explaining why TestTls might fail [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #39171:
URL: https://github.com/apache/arrow/pull/39171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve error message explaining why TestTls might fail [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39171:
URL: https://github.com/apache/arrow/pull/39171#issuecomment-1850205859
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39170: [Java] Improve error message explaining why TestTls might fail [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #39171:
URL: https://github.com/apache/arrow/pull/39171#issuecomment-1851109178
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 7ba022863c75a7d04f16d21b65a66250ac74dbfa.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/19537899320) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39170: [Java] Improve error message explaining why TestTls might fail [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #39171:
URL: https://github.com/apache/arrow/pull/39171#discussion_r1422564020
##########
java/flight/flight-core/src/test/java/org/apache/arrow/flight/FlightTestUtil.java:
##########
@@ -47,7 +48,11 @@ static Path exampleTlsRootCert() {
static List<CertKeyPair> exampleTlsCerts() {
final Path root = getFlightTestDataRoot();
- return Arrays.asList(new CertKeyPair(root.resolve("cert0.pem").toFile(), root.resolve("cert0.pkcs1").toFile()),
+ final Path cert0Pem = root.resolve("cert0.pem");
+ if (!Files.exists(cert0Pem)) {
+ throw new RuntimeException(cert0Pem + " doesn't exist. Take a look on https://arrow.apache.org/docs/dev/developers/java/building.html#building to initialize.");
Review Comment:
```suggestion
throw new RuntimeException(cert0Pem + " doesn't exist. Make sure submodules are initialized (see https://arrow.apache.org/docs/dev/developers/java/building.html#building)");
```
##########
java/flight/flight-core/src/test/java/org/apache/arrow/flight/FlightTestUtil.java:
##########
@@ -47,7 +48,11 @@ static Path exampleTlsRootCert() {
static List<CertKeyPair> exampleTlsCerts() {
final Path root = getFlightTestDataRoot();
- return Arrays.asList(new CertKeyPair(root.resolve("cert0.pem").toFile(), root.resolve("cert0.pkcs1").toFile()),
+ final Path cert0Pem = root.resolve("cert0.pem");
+ if (!Files.exists(cert0Pem)) {
+ throw new RuntimeException(cert0Pem + " doesn't exist. Take a look on https://arrow.apache.org/docs/dev/developers/java/building.html#building to initialize.");
Review Comment:
Something like this, in case the user already knows git?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39170: [Java] Improve error message explaining why TestTls might fail [arrow]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #39171:
URL: https://github.com/apache/arrow/pull/39171#discussion_r1422736340
##########
java/flight/flight-core/src/test/java/org/apache/arrow/flight/FlightTestUtil.java:
##########
@@ -47,7 +48,11 @@ static Path exampleTlsRootCert() {
static List<CertKeyPair> exampleTlsCerts() {
final Path root = getFlightTestDataRoot();
- return Arrays.asList(new CertKeyPair(root.resolve("cert0.pem").toFile(), root.resolve("cert0.pkcs1").toFile()),
+ final Path cert0Pem = root.resolve("cert0.pem");
+ if (!Files.exists(cert0Pem)) {
+ throw new RuntimeException(cert0Pem + " doesn't exist. Take a look on https://arrow.apache.org/docs/dev/developers/java/building.html#building to initialize.");
Review Comment:
Done, thanks again for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39170: [Java] Improve error message explaining why TestTls might fail [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39171:
URL: https://github.com/apache/arrow/pull/39171#issuecomment-1850210130
:warning: GitHub issue #39170 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-39170: [Java] Improve error message explaining why TestTls might fail [arrow]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #39171:
URL: https://github.com/apache/arrow/pull/39171#issuecomment-1850391464
@lidavidm I updated the PR according to your suggestion. Thanks again. This PR is the first one of several coming from me 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org