You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Chaudhari <gi...@sungard.com> on 2014/03/28 08:10:21 UTC
Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a VM in
Simulator results in incorrect size
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Bugs: CLOUDSTACK-5150
https://issues.apache.org/jira/browse/CLOUDSTACK-5150
Repository: cloudstack-git
Description
-------
Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException.
Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue.
Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
Diffs
-----
plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87
Diff: https://reviews.apache.org/r/19779/diff/
Testing
-------
Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
Thanks,
Girish Chaudhari
Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a
VM in Simulator results in incorrect size
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review42162
-----------------------------------------------------------
plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java
<https://reviews.apache.org/r/19779/#comment75883>
I would rather you get the size from the source. Can you have a look?
- daan Hoogland
On March 28, 2014, 7:10 a.m., Girish Chaudhari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 7:10 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException.
> Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue.
> Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
>
>
> Diffs
> -----
>
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87
>
> Diff: https://reviews.apache.org/r/19779/diff/
>
>
> Testing
> -------
>
> Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
>
>
> Thanks,
>
> Girish Chaudhari
>
>
Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a
VM in Simulator results in incorrect size
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45927
-----------------------------------------------------------
Commit 883d8f11196e9ca55324bcf075880e077a2d3df3 in cloudstack's branch refs/heads/4.4-forward from Girish chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=883d8f1 ]
CLOUDSTACK-5150 - set the template size from source
Signed-off-by: Daan Hoogland <da...@onecht.net>
- ASF Subversion and Git Services
On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 9:37 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException.
> Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue.
> Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
>
>
> Diffs
> -----
>
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87
>
> Diff: https://reviews.apache.org/r/19779/diff/
>
>
> Testing
> -------
>
> Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
>
>
> Thanks,
>
> Girish Chaudhari
>
>
Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a
VM in Simulator results in incorrect size
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45929
-----------------------------------------------------------
Commit 591148c4641fd079d7b9b85d30e0c297212984e1 in cloudstack's branch refs/heads/master from Girish chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=591148c ]
CLOUDSTACK-5150 - set the template size from source
Signed-off-by: Daan Hoogland <da...@onecht.net>
(cherry picked from commit 883d8f11196e9ca55324bcf075880e077a2d3df3)
- ASF Subversion and Git Services
On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 9:37 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException.
> Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue.
> Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
>
>
> Diffs
> -----
>
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87
>
> Diff: https://reviews.apache.org/r/19779/diff/
>
>
> Testing
> -------
>
> Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
>
>
> Thanks,
>
> Girish Chaudhari
>
>
Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a
VM in Simulator results in incorrect size
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45931
-----------------------------------------------------------
Commit 5cc5483a7895e7876e336349323a5ea5598d5137 in cloudstack's branch refs/heads/4.4 from Girish chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5cc5483 ]
CLOUDSTACK-5150 - set the template size from source
Signed-off-by: Daan Hoogland <da...@onecht.net>
(cherry picked from commit 883d8f11196e9ca55324bcf075880e077a2d3df3)
- ASF Subversion and Git Services
On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 9:37 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException.
> Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue.
> Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
>
>
> Diffs
> -----
>
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87
>
> Diff: https://reviews.apache.org/r/19779/diff/
>
>
> Testing
> -------
>
> Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
>
>
> Thanks,
>
> Girish Chaudhari
>
>
Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a
VM in Simulator results in incorrect size
Posted by daan Hoogland <da...@gmail.com>.
> On June 17, 2014, 11:42 a.m., daan Hoogland wrote:
> > 883d8f11196e9ca55324bcf075880e077a2d3df3 in 4.4-forward
591148c4641fd079d7b9b85d30e0c297212984e1 on master
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45928
-----------------------------------------------------------
On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 9:37 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException.
> Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue.
> Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
>
>
> Diffs
> -----
>
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87
>
> Diff: https://reviews.apache.org/r/19779/diff/
>
>
> Testing
> -------
>
> Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
>
>
> Thanks,
>
> Girish Chaudhari
>
>
Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a
VM in Simulator results in incorrect size
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/#review45928
-----------------------------------------------------------
Ship it!
883d8f11196e9ca55324bcf075880e077a2d3df3 in 4.4-forward
- daan Hoogland
On June 17, 2014, 9:37 a.m., Girish Chaudhari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19779/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 9:37 a.m.)
>
>
> Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-5150
> https://issues.apache.org/jira/browse/CLOUDSTACK-5150
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException.
> Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue.
> Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
>
>
> Diffs
> -----
>
> plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87
>
> Diff: https://reviews.apache.org/r/19779/diff/
>
>
> Testing
> -------
>
> Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
>
>
> Thanks,
>
> Girish Chaudhari
>
>
Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a
VM in Simulator results in incorrect size
Posted by Girish Chaudhari <gi...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/
-----------------------------------------------------------
(Updated June 17, 2014, 9:37 a.m.)
Review request for cloudstack, daan Hoogland and Prasanna Santhanam.
Bugs: CLOUDSTACK-5150
https://issues.apache.org/jira/browse/CLOUDSTACK-5150
Repository: cloudstack-git
Description
-------
Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException.
Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue.
Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
Diffs
-----
plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87
Diff: https://reviews.apache.org/r/19779/diff/
Testing
-------
Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
Thanks,
Girish Chaudhari
Re: Review Request 19779: Fixed[CLOUDSTACK-5150]:-Creating template from a
VM in Simulator results in incorrect size
Posted by Girish Chaudhari <gi...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19779/
-----------------------------------------------------------
(Updated May 19, 2014, 6:21 a.m.)
Review request for cloudstack and Prasanna Santhanam.
Changes
-------
I have modified the fix to take the size from source.
I have tested this on 4.3 as well as on 4.4-forward branch. It should work on master as well.
Bugs: CLOUDSTACK-5150
https://issues.apache.org/jira/browse/CLOUDSTACK-5150
Repository: cloudstack-git
Description
-------
Problem Statement:- In Simulator, When provisioning the VM using the personal template, results into the NullPointerException.
Root Cause:- The template creation command is setting up the size as NULL in the tempalte_store_ref table and which is something causing this issue.
Solution: To set up the size to 100 ( any Non-Null value) in the template create mocking process, which ultimately setting up the size to 100 in the tempalte_store_ref table and hence solving the issue.
Diffs (updated)
-----
plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java 8a78b87
Diff: https://reviews.apache.org/r/19779/diff/
Testing
-------
Tested it on the 4.3, the size in tempalte_store_ref table is getting populated as 100 and could instantiate the VM using the personal template.
Thanks,
Girish Chaudhari