You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/05/22 20:05:12 UTC
[jira] [Commented] (GORA-465) Remove @Deprecated logic for
hbase-mapping.xml
[ https://issues.apache.org/jira/browse/GORA-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295706#comment-15295706 ]
ASF GitHub Bot commented on GORA-465:
-------------------------------------
GitHub user cguzel opened a pull request:
https://github.com/apache/gora/pull/67
GORA-465 remove deprecated logic
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cguzel/gora GORA-465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/gora/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit afbc68e6669f0b566eaf05c8872d45ee1bc4db17
Author: cihad guzel <cg...@gmail.com>
Date: 2016-05-22T19:56:08Z
GORA-465 remove deprecated logic
----
> Remove @Deprecated logic for hbase-mapping.xml
> ----------------------------------------------
>
> Key: GORA-465
> URL: https://issues.apache.org/jira/browse/GORA-465
> Project: Apache Gora
> Issue Type: Test
> Components: gora-hbase
> Affects Versions: 0.6.1
> Reporter: Lewis John McGibbney
> Priority: Trivial
> Fix For: 0.8
>
>
> We have some useless checking and log statements in HBaseStore which relate to a very old hbase-mapping.xml.
> These should just be removed.
> {code}
> @Deprecated
> private static final String DEPRECATED_MAPPING_FILE = "hbase-mapping.xml";
> ...
> try {
> mapping = readMapping(getConf().get(PARSE_MAPPING_FILE_KEY, DEPRECATED_MAPPING_FILE));
> LOG.warn("{} is deprecated, please rename the file to {}", DEPRECATED_MAPPING_FILE, DEFAULT_MAPPING_FILE);
> } catch (FileNotFoundException ex1) {
> LOG.error(ex1.getMessage(), ex1);
> //throw (ex1); //throw the original exception
> } catch (Exception ex1) {
> LOG.warn("{} is deprecated, please rename the file to {}", DEPRECATED_MAPPING_FILE, DEFAULT_MAPPING_FILE);
> throw new RuntimeException(ex1);
> }
> {code}
> etc
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)