[GitHub] [arrow] jorgecarleitao commented on pull request #8401: ARROW-10109: [Rust] Add support to the C data interface for primitive types and utf8

[GitBox <gi...@apache.org>]

jorgecarleitao commented on pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#issuecomment-725242639


   @nevi-me , @andygrove @pitrou @alamb , I have rebased this PR. 
   
   I need your guidance here:
   
   * is this something that we still want to pursue, or should we close this? If open:
   * Currently the memory track is done with a feature gate. This is faster, but requires a new compilation to run the tests with that feature gate.
   * Currently it tests memory leaks via a test at the end of all tests (and under the feature gate). This covers all tests implicitely, but tests that panic are intrinsically leaky and thus there is a non-trivial interaction between tests and the memory check test.
   * The integration test with Python/C++ requires another compilation, with other compiler flags, which is an extra CI burden.
   
   Some ideas:
   
   * Refactor the memory test check to be on a per-test basis, so that we do not have interactions between tests. The positive is that we won't get tests interactions. The downside is that we need to be explicit in performing the memory check on each test we want.
   * Make the allocation/deallocation outside the feature gate. This may make the code slower (I need to profile) as we need to handle an thread-atomic lock of a counter, but it significantly reduces the complexity around CI (no need to re-compile with a different feature gate).
   * Make the Python/C++ tests use C++ libs and headers instead of running against pyarrow. This is something that I do not know how to do, so it will take me some time.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org