You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/06 19:50:43 UTC

Review Request 43289: Add missing mesos/appc/spec.proto in CMakefile.txt.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43289/
-----------------------------------------------------------

Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-4617
    https://issues.apache.org/jira/browse/MESOS-4617


Repository: mesos


Description
-------

Add missing mesos/appc/spec.proto in CMakefile.txt.


Diffs
-----

  src/CMakeLists.txt 4a2954498efa48a4eb43f82827ff1d6f5f65d389 

Diff: https://reviews.apache.org/r/43289/diff/


Testing
-------


Thanks,

haosdent huang


Re: Review Request 43289: Add missing mesos/appc/spec.proto in CMakefile.txt.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43289/#review118163
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43289]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 6, 2016, 6:50 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43289/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4617
>     https://issues.apache.org/jira/browse/MESOS-4617
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add missing mesos/appc/spec.proto in CMakefile.txt.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4a2954498efa48a4eb43f82827ff1d6f5f65d389 
> 
> Diff: https://reviews.apache.org/r/43289/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 43289: Add missing mesos/appc/spec.proto in CMakefile.txt.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43289/#review118164
-----------------------------------------------------------


Ship it!




Ship It!

- Guangya Liu


On 二月 6, 2016, 6:50 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43289/
> -----------------------------------------------------------
> 
> (Updated 二月 6, 2016, 6:50 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4617
>     https://issues.apache.org/jira/browse/MESOS-4617
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add missing mesos/appc/spec.proto in CMakefile.txt.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 4a2954498efa48a4eb43f82827ff1d6f5f65d389 
> 
> Diff: https://reviews.apache.org/r/43289/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>