You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/09/25 19:04:03 UTC

[GitHub] markusthoemmes commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety

markusthoemmes commented on a change in pull request #2802: Akka Usage Cleanup for Actor State safety
URL: https://github.com/apache/incubator-openwhisk/pull/2802#discussion_r140866347
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
 ##########
 @@ -258,7 +257,7 @@ protected[actions] object ActivationFinisher {
     // when the future completes, self-destruct
     promise.future.andThen { case _ => shutdown() }
 
-    val preemptiveMsgs: Buffer[Cancellable] = Buffer.empty
+    var preemptiveMsgs = Vector.empty[Cancellable]
 
 Review comment:
   Mega nit: Should this be an `immutable.Buffer` for its constant append time?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services