You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/11/09 23:12:26 UTC
[Impala-ASF-CR] [BE] flag for Kudu connection negotiation timeout
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16705
Change subject: [BE] flag for Kudu connection negotiation timeout
......................................................................
[BE] flag for Kudu connection negotiation timeout
This patch adds --kudu_client_connection_negotiation_timeout_ms flag
to control client-side connection negotiation timeout in the Kudu
client working as a part of the Impala's BE. Since [1] has been
addressed for Kudu C++ client, it makes sense to provide a control knob
to customize the timeout. That should help to address cases where very
busy cluster nodes hosting Kudu tablet servers aren't fast enough to
negotiate a new connection within the default timeout interval (3 sec),
as mentioned in the description of [1].
[1] https://issues.apache.org/jira/browse/KUDU-2966
Change-Id: I1223187318691da47082608356547f6d78144466
---
M be/src/common/global-flags.cc
M be/src/exec/kudu-util.cc
2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/16705/1
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10472 flag for Kudu connection negotiation timeout
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: IMPALA-10472 flag for Kudu connection negotiation timeout
......................................................................
IMPALA-10472 flag for Kudu connection negotiation timeout
This patch adds --kudu_client_connection_negotiation_timeout_ms flag
to control client-side connection negotiation timeout in the Kudu
client working as a part of the Impala's BE. Since [1] has been
addressed for Kudu C++ client, it makes sense to provide a control knob
to customize the timeout. That should help to address cases where very
busy cluster nodes hosting Kudu tablet servers aren't fast enough to
negotiate a new connection within the default timeout interval (3 sec),
as mentioned in the description of [1].
[1] https://issues.apache.org/jira/browse/KUDU-2966
Change-Id: I1223187318691da47082608356547f6d78144466
Reviewed-on: http://gerrit.cloudera.org:8080/16705
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/global-flags.cc
M be/src/exec/kudu-util.cc
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Thomas Tauber-Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10472 flag for Kudu connection negotiation timeout
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16705
to look at the new patch set (#3).
Change subject: IMPALA-10472 flag for Kudu connection negotiation timeout
......................................................................
IMPALA-10472 flag for Kudu connection negotiation timeout
This patch adds --kudu_client_connection_negotiation_timeout_ms flag
to control client-side connection negotiation timeout in the Kudu
client working as a part of the Impala's BE. Since [1] has been
addressed for Kudu C++ client, it makes sense to provide a control knob
to customize the timeout. That should help to address cases where very
busy cluster nodes hosting Kudu tablet servers aren't fast enough to
negotiate a new connection within the default timeout interval (3 sec),
as mentioned in the description of [1].
[1] https://issues.apache.org/jira/browse/KUDU-2966
Change-Id: I1223187318691da47082608356547f6d78144466
---
M be/src/common/global-flags.cc
M be/src/exec/kudu-util.cc
2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/16705/3
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10472 flag for Kudu connection negotiation timeout
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: IMPALA-10472 flag for Kudu connection negotiation timeout
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16705/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16705/2//COMMIT_MSG@7
PS2, Line 7: [BE] flag for Kudu connection negotiation timeout
> I know it probably feels like overkill for such a small patch, but we gener
Done
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 23:53:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [BE] flag for Kudu connection negotiation timeout
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: [BE] flag for Kudu connection negotiation timeout
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16705/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16705/2//COMMIT_MSG@7
PS2, Line 7: [BE] flag for Kudu connection negotiation timeout
I know it probably feels like overkill for such a small patch, but we generally prefer to have an Impala JIRA for pretty much every change
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Feb 2021 23:20:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [BE] flag for Kudu connection negotiation timeout
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: [BE] flag for Kudu connection negotiation timeout
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/7625/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 23:25:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10472 flag for Kudu connection negotiation timeout
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: IMPALA-10472 flag for Kudu connection negotiation timeout
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 00:00:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [BE] flag for Kudu connection negotiation timeout
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: [BE] flag for Kudu connection negotiation timeout
......................................................................
Patch Set 1:
> > Build Failed
> >
> > https://jenkins.impala.io/job/gerrit-code-review-checks/7625/ :
> > Initial code review checks failed. See linked job for details on
> > the failure.
>
> Whoops, it seems the version of Kudu client that Impala uses
> doesn't include the necessary changes implemented as part of
> KUDU-2966: https://jenkins.impala.io/job/ubuntu-16.04-build-only/12832/console
>
> I guess I should re-submit this patch after the newly introduced
> functionality in Kudu client is released in with Kudu 1.14.
>
> Anyways, it would be great to get some feedback on this change.
>
> Thanks!
Yeah, you'll need to bump the version of Kudu in native toolchain: https://github.com/cloudera/native-toolchain/blob/master/buildall.sh#L322
Otherwise, this patch looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Nov 2020 19:47:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10472 flag for Kudu connection negotiation timeout
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: IMPALA-10472 flag for Kudu connection negotiation timeout
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 05:42:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10472 flag for Kudu connection negotiation timeout
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: IMPALA-10472 flag for Kudu connection negotiation timeout
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6870/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Feb 2021 00:02:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [BE] flag for Kudu connection negotiation timeout
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16705 )
Change subject: [BE] flag for Kudu connection negotiation timeout
......................................................................
Patch Set 1:
> Build Failed
>
> https://jenkins.impala.io/job/gerrit-code-review-checks/7625/ :
> Initial code review checks failed. See linked job for details on
> the failure.
Whoops, it seems the version of Kudu client that Impala uses doesn't include the necessary changes implemented as part of KUDU-2966: https://jenkins.impala.io/job/ubuntu-16.04-build-only/12832/console
I guess I should re-submit this patch after the newly introduced functionality in Kudu client is released in with Kudu 1.14.
Anyways, it would be great to get some feedback on this change.
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/16705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1223187318691da47082608356547f6d78144466
Gerrit-Change-Number: 16705
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2020 23:34:46 +0000
Gerrit-HasComments: No