You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Hyukjin Kwon (JIRA)" <ji...@apache.org> on 2019/05/21 04:14:30 UTC

[jira] [Resolved] (SPARK-20013) merge renameTable to alterTable in ExternalCatalog

     [ https://issues.apache.org/jira/browse/SPARK-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hyukjin Kwon resolved SPARK-20013.
----------------------------------
    Resolution: Incomplete

> merge renameTable to alterTable in ExternalCatalog
> --------------------------------------------------
>
>                 Key: SPARK-20013
>                 URL: https://issues.apache.org/jira/browse/SPARK-20013
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.2.0
>            Reporter: Song Jun
>            Priority: Major
>              Labels: bulk-closed
>
> Currently when we create / rename a managed table, we should get the defaultTablePath for them in ExternalCatalog, then we have two defaultTablePath logic in its two subclass HiveExternalCatalog and InMemoryCatalog, additionally there is also a defaultTablePath in SessionCatalog, so till now we have three defaultTablePath in three classes. 
> we'd better to unify them up to SessionCatalog
> To unify them, we should move some logic from ExternalCatalog to SessionCatalog, renameTable is one of this.
> while limit to the simple parameters in renameTable 
> {code}
>   def renameTable(db: String, oldName: String, newName: String): Unit
> {code}
> even if we move the defaultTablePath logic to SessionCatalog, we can not pass it to renameTable.
> So we can add a newTablePath parameter  for renameTable in ExternalCatalog 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org