You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/09/18 19:18:59 UTC
Review Request 38497: Introduced Executor HTTP endpoint on Agent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38497/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907
Repository: mesos
Description
-------
This change introduces a stub endpoint on Agent. As of now, it doesn't do much except validating the `Content-Type`, `Accept` headers among other trivial validations. Most of the functionality already existed in `src/master/http.cpp`
Diffs
-----
src/slave/http.cpp 101aa06e981eaa43bf6c68268b057f3d15e33e2e
src/slave/slave.hpp 32e18305f3b630ab5f4e7aca2ef14cdb14c10721
src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287
Diff: https://reviews.apache.org/r/38497/diff/
Testing
-------
make check + tests in r38499
Thanks,
Anand Mazumdar
Re: Review Request 38497: Introduced Executor HTTP endpoint on Agent
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38497/#review99779
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On Sept. 18, 2015, 5:18 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38497/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 5:18 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces a stub endpoint on Agent. As of now, it doesn't do much except validating the `Content-Type`, `Accept` headers among other trivial validations. Most of the functionality already existed in `src/master/http.cpp`
>
>
> Diffs
> -----
>
> src/slave/http.cpp 101aa06e981eaa43bf6c68268b057f3d15e33e2e
> src/slave/slave.hpp 32e18305f3b630ab5f4e7aca2ef14cdb14c10721
> src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287
>
> Diff: https://reviews.apache.org/r/38497/diff/
>
>
> Testing
> -------
>
> make check + tests in r38499
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38497: Introduced Executor HTTP endpoint on Agent
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38497/#review99590
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 18, 2015, 5:18 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38497/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 5:18 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces a stub endpoint on Agent. As of now, it doesn't do much except validating the `Content-Type`, `Accept` headers among other trivial validations. Most of the functionality already existed in `src/master/http.cpp`
>
>
> Diffs
> -----
>
> src/slave/http.cpp 101aa06e981eaa43bf6c68268b057f3d15e33e2e
> src/slave/slave.hpp 32e18305f3b630ab5f4e7aca2ef14cdb14c10721
> src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287
>
> Diff: https://reviews.apache.org/r/38497/diff/
>
>
> Testing
> -------
>
> make check + tests in r38499
>
>
> Thanks,
>
> Anand Mazumdar
>
>