You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/11 13:08:23 UTC

[GitHub] [flink] rkhachatryan commented on a diff in pull request #20240: [FLINK-26621][tests] Close delegate keyed state backend

rkhachatryan commented on code in PR #20240:
URL: https://github.com/apache/flink/pull/20240#discussion_r917908521


##########
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestUtils.java:
##########
@@ -176,6 +176,16 @@ public RunnableFuture<SnapshotResult<KeyedStateHandle>> snapshot(
                                     checkpointId, timestamp, streamFactory, checkpointOptions);
                     return snapshotResultFunction.apply(snapshotResultRunnableFuture);
                 }
+
+                @Override
+                public void dispose() {
+                    delegatedKeyedStateBackend.dispose();
+                }

Review Comment:
   Do we also need to call `super.dispose`?
   
   ditto: `close()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org