You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/07/18 01:52:32 UTC
Review Request 71109: Added helpers to return resources
allocated/reserved to a role subtree.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71109/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
Added helpers to return resources allocated/reserved to a role subtree.
Diffs
-----
include/mesos/resources.hpp 3fc2c34b383cf1cabfb5367a72e0e71a1aed4238
include/mesos/v1/resources.hpp 39c04035263cb9f96e957d1fb80ab0cc8313f97d
src/common/resources.cpp 6e02d5c7cd479d4a8161260df2eba7ae0a4e9b6d
src/v1/resources.cpp 25fb2136c0ecae4102bc7dfc72cdb5d8ceeff836
Diff: https://reviews.apache.org/r/71109/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71109: Added helpers to return resources
allocated/reserved to a role subtree.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71109/#review216733
-----------------------------------------------------------
Ship it!
Any reason not to update the resources_tests.cpp to test this?
- Benjamin Mahler
On July 18, 2019, 1:52 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71109/
> -----------------------------------------------------------
>
> (Updated July 18, 2019, 1:52 a.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helpers to return resources allocated/reserved to a role subtree.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 3fc2c34b383cf1cabfb5367a72e0e71a1aed4238
> include/mesos/v1/resources.hpp 39c04035263cb9f96e957d1fb80ab0cc8313f97d
> src/common/resources.cpp 6e02d5c7cd479d4a8161260df2eba7ae0a4e9b6d
> src/v1/resources.cpp 25fb2136c0ecae4102bc7dfc72cdb5d8ceeff836
>
>
> Diff: https://reviews.apache.org/r/71109/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>