You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/22 14:00:00 UTC
[jira] [Work logged] (HIVE-22525) Refactor HiveOpConverter
[ https://issues.apache.org/jira/browse/HIVE-22525?focusedWorklogId=348151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348151 ]
ASF GitHub Bot logged work on HIVE-22525:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/19 13:59
Start Date: 22/Nov/19 13:59
Worklog Time Spent: 10m
Work Description: miklosgergely commented on pull request #850: HIVE-22525 Refactor HiveOpConverter
URL: https://github.com/apache/hive/pull/850
HiveOpConverter is on it's way to become a monster class. It is already ~1300 lines long, and expected to grow. It should be refactored, cut into multiple classes in a reasonable way. It is a natural way to do this is to create separate visitor classes for the different RelNodes, which are already handled in different functions within HiveOpConverter. That way HiveOpConverter can be the dispatcher among those visitor classes, while each of them are handling some specific work, potentially requesting sub nodes to be dispatched by HiveOpConverter. The functions used by multiple visitors should be put into some utility class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 348151)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor HiveOpConverter
> ------------------------
>
> Key: HIVE-22525
> URL: https://issues.apache.org/jira/browse/HIVE-22525
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22525.01.patch, HIVE-22525.02.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> HiveOpConverter is on it's way to become a monster class. It is already ~1300 lines long, and expected to grow. It should be refactored, cut into multiple classes in a reasonable way. It is a natural way to do this is to create separate visitor classes for the different RelNodes, which are already handled in different functions within HiveOpConverter. That way HiveOpConverter can be the dispatcher among those visitor classes, while each of them are handling some specific work, potentially requesting sub nodes to be dispatched by HiveOpConverter. The functions used by multiple visitors should be put into some utility class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)