You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/08 06:30:55 UTC
[GitHub] [hudi] xushiyan commented on a change in pull request #1871: [WIP] [HUDI-781] Introduce HoodieTestTable for test preparation
xushiyan commented on a change in pull request #1871:
URL: https://github.com/apache/hudi/pull/1871#discussion_r467367212
##########
File path: hudi-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java
##########
@@ -74,57 +74,6 @@
public class HoodieClientTestUtils {
Review comment:
deleted APIs that turn out be to useful moved to org.apache.hudi.common.testutils.FilesTestUtils
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java
##########
@@ -99,7 +99,6 @@
*/
public class HoodieTestUtils {
- public static final String TEST_EXTENSION = ".test";
Review comment:
not used
##########
File path: hudi-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java
##########
@@ -227,6 +176,8 @@ public static SparkConf getSparkConfForTest(String appName) {
/**
* Find total basefiles for passed in paths.
+ *
+ * @deprecated Use {@link HoodieTestTable} instead.
Review comment:
mark deprecated to prevent new usage; also as a reminder to migrate in future PRs. Similar to other deprecated marks.
##########
File path: hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java
##########
@@ -279,8 +268,8 @@ public static String createDataFile(String basePath, String partitionPath, Strin
return fileID;
}
- public static String createDataFileFixLength(String basePath, String partitionPath, String instantTime, String fileID,
- long length) throws IOException {
+ private static String createDataFileFixLength(String basePath, String partitionPath, String instantTime, String fileID,
Review comment:
mark private to prevent new usage. to be replaced with HoodieTestTable, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org