You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 21:45:34 UTC
[PR] [ISSUE-3807][test] Deepen PasswordHasherTest with null, malformed and iteration-bound guards [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3807:
URL: https://github.com/apache/rocketmq-dashboard/pull/3807
### Motivation
The existing `PasswordHasherTest` proves salt uniqueness, verification and the salt/digest length guards, but the remaining `matches` guards — null arguments, structurally malformed hashes and out-of-range iteration counts — were untested.
### Changes
- `matchesShouldRejectNullArguments`: a null password or stored hash never verifies.
- `matchesShouldRejectMalformedHashFormat`: non-hash strings, wrong scheme prefixes and non-numeric iteration counts are rejected before any key derivation.
- `matchesShouldRejectIterationsOutsideAllowedBounds`: iteration counts below 100k or above 1M (with otherwise valid salt/digest segments) are rejected.
### Verification
```
mvn -B test -Dtest=PasswordHasherTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
[INFO] BUILD SUCCESS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE-3807][test] Deepen PasswordHasherTest with null, malformed and iteration-bound guards [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3807: [ISSUE-3807][test] Deepen PasswordHasherTest with null, malformed and iteration-bound guards
URL: https://github.com/apache/rocketmq-dashboard/pull/3807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org