You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by David Stenglein <da...@sputnik7.com> on 2002/05/20 22:44:38 UTC

[PATCH] Additional testcase for Filter

There is no testcase for Filter that covers the use of an external
properties file for the definition of filters. Hope this is in a
useful format. If not, please let me know.

BTW, made this test while modifying filter to accept xmlproperties for
filter definitions (which appears to be working).

-Dave


-- 
---
David Stenglein
Director of Engineering/Operations
sputnik7.com
dave at sputnik7.com
---

Re: [PATCH] Additional testcase for Filter

Posted by Stefan Bodewig <bo...@apache.org>.
On 21 May 2002, David Stenglein <da...@sputnik7.com> wrote:

> Actually, that's what I did. I took the code from XMLproperty and
> made a new util.Properties that subclasses java.util.Properties.

Sounds as if we should combine this effort with some other places
where Properties/XML can be used as twins.

There is echoproerties and loadproperties and friends, where work has
already been done.  And then there is <translate> and a similar XML
based task by Henri Gomez.

Maybe it would be good to create an abstraction that is used by all
these tasks?

> Also, where would this functionality go release-wise, post 1.5?

1.6, no question.

Stefan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [PATCH] Additional testcase for Filter

Posted by David Stenglein <da...@sputnik7.com>.
On Tue, 2002-05-21 at 09:11, Stefan Bodewig wrote:
> On 20 May 2002, David Stenglein <da...@sputnik7.com> wrote:
> 
> > There is no testcase for Filter that covers the use of an external
> > properties file for the definition of filters.
> 
> Thanks, I've committed it.
> 
> > BTW, made this test while modifying filter to accept xmlproperties
> > for filter definitions (which appears to be working).
> 
> I haven't followed this area closely, but I guess you should add this
> to the stuff related to FilterSet rather than the filter task.
> 

Actually, that's what I did. I took the code from XMLproperty and made
a new util.Properties that subclasses java.util.Properties. The
XMLproperty task now uses this as does the FilterSet. Filter needed to
be modified to allow a different format for the properties and to
pass through some XML parsing options.

Does this sound alright?  The only thing that bothers me about this is
adding all of the XML parsing options to the Filter task, and eventually
Replace.

Also, where would this functionality go release-wise, post 1.5?


-Dave



> Stefan
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
-- 
---
David Stenglein
Director of Engineering/Operations
sputnik7.com
dave at sputnik7.com
---



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [PATCH] Additional testcase for Filter

Posted by Stefan Bodewig <bo...@apache.org>.
On 20 May 2002, David Stenglein <da...@sputnik7.com> wrote:

> There is no testcase for Filter that covers the use of an external
> properties file for the definition of filters.

Thanks, I've committed it.

> BTW, made this test while modifying filter to accept xmlproperties
> for filter definitions (which appears to be working).

I haven't followed this area closely, but I guess you should add this
to the stuff related to FilterSet rather than the filter task.

Stefan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>