You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/04 12:27:19 UTC
[GitHub] [incubator-superset] amitmiran137 opened a new pull request #12210: feat: Custom color schemes support
amitmiran137 opened a new pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210
### SUMMARY
Today colors schemes are loaded from @superset-ui/core
we should have support for individual deployments to inject their own sets of color scheme
the mechanism was copied from setup plugins logic
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (47a846b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.57%`.
> The diff coverage is `5.26%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 62.63% -3.58%
==========================================
Files 996 1002 +6
Lines 49174 49218 +44
Branches 4993 5005 +12
==========================================
- Hits 32554 30826 -1728
- Misses 16476 18192 +1716
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.21% <0.00%> (+0.09%)` | :arrow_up: |
| python | `63.55% <100.00%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-56.53%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (47a846b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `4.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 61.21% -5.00%
==========================================
Files 996 517 -479
Lines 49174 19402 -29772
Branches 4993 5005 +12
==========================================
- Hits 32554 11876 -20678
+ Misses 16476 7326 -9150
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.21% <0.00%> (+0.09%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-56.53%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [642 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro closed pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (47a846b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.23%`.
> The diff coverage is `5.26%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 62.96% -3.24%
==========================================
Files 996 1002 +6
Lines 49174 49233 +59
Branches 4993 5005 +12
==========================================
- Hits 32554 31002 -1552
- Misses 16476 18031 +1555
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.21% <0.00%> (+0.09%)` | :arrow_up: |
| python | `64.11% <100.00%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-56.53%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 closed pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (123569f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `15.22%`.
> The diff coverage is `76.47%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
===========================================
- Coverage 66.20% 50.98% -15.23%
===========================================
Files 996 466 -530
Lines 49174 16773 -32401
Branches 4993 4309 -684
===========================================
- Hits 32554 8551 -24003
+ Misses 16476 8222 -8254
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <76.47%> (+6.88%)` | :arrow_up: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `77.77% <55.55%> (-22.23%)` | :arrow_down: |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `88.46% <100.00%> (+31.93%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [879 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on a change in pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#discussion_r551835442
##########
File path: superset-frontend/src/setup/setupColors.js
##########
@@ -49,4 +50,6 @@ export default function setupColors() {
});
});
sequentialSchemeRegistry.setDefaultKey('superset_seq_1');
+
+ setupColorsExtra();
Review comment:
hi @mistercrunch I really liked your idea and added another commit supporting color schemes from the config.py file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#discussion_r551557453
##########
File path: superset-frontend/src/setup/setupColors.js
##########
@@ -49,4 +50,6 @@ export default function setupColors() {
});
});
sequentialSchemeRegistry.setDefaultKey('superset_seq_1');
+
+ setupColorsExtra();
Review comment:
Should we pass the context here as in
```
const colorContext = {sequentialSchemeRegistry, categoricalSchemeRegistry};
setupColorsConfigHook(colorContext);
```
(or similar)?
I'm also wondering if we should have a central file for all the configuration hooks, similar to `superset/config.py` on the python side?
##########
File path: superset-frontend/src/setup/setupColors.js
##########
@@ -49,4 +50,6 @@ export default function setupColors() {
});
});
sequentialSchemeRegistry.setDefaultKey('superset_seq_1');
+
+ setupColorsExtra();
Review comment:
Should we pass the context here as in
```js
const colorContext = {sequentialSchemeRegistry, categoricalSchemeRegistry};
setupColorsConfigHook(colorContext);
```
(or similar)?
I'm also wondering if we should have a central file for all the configuration hooks, similar to `superset/config.py` on the python side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 closed pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#discussion_r551557453
##########
File path: superset-frontend/src/setup/setupColors.js
##########
@@ -49,4 +50,6 @@ export default function setupColors() {
});
});
sequentialSchemeRegistry.setDefaultKey('superset_seq_1');
+
+ setupColorsExtra();
Review comment:
Should we pass the context here as in
```js
const colorContext = {sequentialSchemeRegistry, categoricalSchemeRegistry};
setupColorsConfigHook(colorContext);
```
(or similar)? Otherwise we're assuming the users are importing things and it feels monkey-patchy...
I'm also wondering if we should have a central file for all the configuration hooks, similar to `superset/config.py` on the python side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (47a846b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.31%`.
> The diff coverage is `5.26%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 62.88% -3.32%
==========================================
Files 996 1002 +6
Lines 49174 49233 +59
Branches 4993 5005 +12
==========================================
- Hits 32554 30959 -1595
- Misses 16476 18074 +1598
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.21% <0.00%> (+0.09%)` | :arrow_up: |
| python | `63.97% <100.00%> (-0.26%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-56.53%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (fa8b08f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.30%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 63.89% -2.31%
==========================================
Files 996 485 -511
Lines 49174 29795 -19379
Branches 4993 0 -4993
==========================================
- Hits 32554 19037 -13517
+ Misses 16476 10758 -5718
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.89% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.89% <0.00%> (-2.48%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.44% <0.00%> (-1.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.27% <0.00%> (-1.81%)` | :arrow_down: |
| ... and [519 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...fa8b08f](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 closed pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 closed pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#discussion_r551557453
##########
File path: superset-frontend/src/setup/setupColors.js
##########
@@ -49,4 +50,6 @@ export default function setupColors() {
});
});
sequentialSchemeRegistry.setDefaultKey('superset_seq_1');
+
+ setupColorsExtra();
Review comment:
Should we pass the context here as in
```js
const colorContext = {sequentialSchemeRegistry, categoricalSchemeRegistry};
setupColorsConfigHook(colorContext);
```
(or similar)? Otherwise we're assuming the users are importing arbitrary objects and mutating them and it feels monkey-patchy...
I'm also wondering if we should have a central file for all the configuration hooks, similar to `superset/config.py` on the python side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 commented on a change in pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on a change in pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#discussion_r551910554
##########
File path: docs/src/pages/docs/frequently-asked-questions-page.mdx
##########
@@ -232,6 +232,29 @@ Metadata attribute using the `label_colors` key.
}
```
+### Is there a way to add custom color schemes?
+
+It is possible to override SETUP_EXTRA with COLOR_SCHEMES to register new color schemes
+
+```
+SETUP_EXTRA = {"COLOR_SCHEMES": [
+ {
+ "id": 'myCustomColors',
+ "schemeType": 'Categorical', //Categorical or Sequential
+ "description": '',
+ "label": 'My custom Colors',
+ "colors": ['#6BD3B3', '#6BD3B3', '#6BD3B3', '#66CBE2']
+ }]
+}
Review comment:
makes sense. added changes accordingly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (47a846b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.22%`.
> The diff coverage is `5.26%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 62.97% -3.23%
==========================================
Files 996 1002 +6
Lines 49174 49233 +59
Branches 4993 5005 +12
==========================================
- Hits 32554 31005 -1549
- Misses 16476 18028 +1552
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.21% <0.00%> (+0.09%)` | :arrow_up: |
| python | `64.12% <100.00%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-56.53%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#discussion_r549901617
##########
File path: docs/src/pages/docs/frequently-asked-questions-page.mdx
##########
@@ -232,6 +232,28 @@ Metadata attribute using the `label_colors` key.
}
```
+### Is there a way to add custom color schemes?
+
+It is possible to override [setupColorsExtra.ts](/src/setup/setupColorsExtra.ts) to register new color schemes
+
+```
+import CategoricalScheme from '../../CategoricalScheme'; // Can use existing scheme type or create new types
Review comment:
Should this be `import { CategoricalScheme } from '@superset-ui/core';`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (d6a5db0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.75%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 63.44% -2.76%
==========================================
Files 996 485 -511
Lines 49174 29831 -19343
Branches 4993 0 -4993
==========================================
- Hits 32554 18926 -13628
+ Misses 16476 10905 -5571
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.44% <100.00%> (-0.78%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `74.67% <0.00%> (-8.66%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.38% <0.00%> (-6.71%)` | :arrow_down: |
| ... and [528 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (fa8b08f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `7.11%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 59.08% -7.12%
==========================================
Files 996 947 -49
Lines 49174 46797 -2377
Branches 4993 4427 -566
==========================================
- Hits 32554 27650 -4904
- Misses 16476 19147 +2671
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.65% <100.00%> (+6.55%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.89% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/setup/setupColorsExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzRXh0cmEudHM=) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [407 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...fa8b08f](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (fa8b08f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.81%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 63.38% -2.82%
==========================================
Files 996 485 -511
Lines 49174 29795 -19379
Branches 4993 0 -4993
==========================================
- Hits 32554 18886 -13668
+ Misses 16476 10909 -5567
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <ø> (-0.84%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.22% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [522 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...fa8b08f](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#discussion_r551863593
##########
File path: docs/src/pages/docs/frequently-asked-questions-page.mdx
##########
@@ -232,6 +232,29 @@ Metadata attribute using the `label_colors` key.
}
```
+### Is there a way to add custom color schemes?
+
+It is possible to override SETUP_EXTRA with COLOR_SCHEMES to register new color schemes
+
+```
+SETUP_EXTRA = {"COLOR_SCHEMES": [
+ {
+ "id": 'myCustomColors',
+ "schemeType": 'Categorical', //Categorical or Sequential
+ "description": '',
+ "label": 'My custom Colors',
+ "colors": ['#6BD3B3', '#6BD3B3', '#6BD3B3', '#66CBE2']
+ }]
+}
+.
+.
+.
+schemes.forEach(scheme => {
+ categoricalSchemeRegistry.registerValue(scheme.id, scheme);
+});
Review comment:
Is this needed here? The FAQ should probably explain that the change should be done in `superset_config.py`.
##########
File path: docs/src/pages/docs/frequently-asked-questions-page.mdx
##########
@@ -232,6 +232,29 @@ Metadata attribute using the `label_colors` key.
}
```
+### Is there a way to add custom color schemes?
+
+It is possible to override SETUP_EXTRA with COLOR_SCHEMES to register new color schemes
+
+```
+SETUP_EXTRA = {"COLOR_SCHEMES": [
+ {
+ "id": 'myCustomColors',
+ "schemeType": 'Categorical', //Categorical or Sequential
+ "description": '',
+ "label": 'My custom Colors',
+ "colors": ['#6BD3B3', '#6BD3B3', '#6BD3B3', '#66CBE2']
+ }]
+}
Review comment:
`SETUP_EXTRA` feels ambiguous, and will be difficult/disruptive to change once introduced. Perhaps break this up into `EXTRA_COLOR_SCHEMES` or even `EXTRA_CATEGORICAL_COLOR_SCHEMES` and `EXTRA_SEQUENTIAL_COLOR_SCEHEMES` would make sense?
##########
File path: superset-frontend/src/preamble.ts
##########
@@ -20,6 +20,7 @@ import { setConfig as setHotLoaderConfig } from 'react-hot-loader';
import 'abortcontroller-polyfill/dist/abortcontroller-polyfill-only';
import moment from 'moment';
import { configure } from '@superset-ui/core';
+import ColorScheme from '@superset-ui/core/lib/color/ColorScheme';
Review comment:
We should probably export this (and other related ones) in `@superset-ui/core`.
##########
File path: superset-frontend/src/preamble.ts
##########
@@ -49,7 +52,17 @@ if (typeof window !== 'undefined') {
setupClient();
// Setup color palettes
-setupColors();
+let color_schemas: ColorScheme[] = [];
+
+if (
+ bootstrapData.common &&
+ bootstrapData.common.setup_extra &&
+ bootstrapData.common.setup_extra.COLOR_SCHEMES
+) {
+ color_schemas = bootstrapData.common.setup_extra.COLOR_SCHEMES;
+}
+
+setupColors(color_schemas);
Review comment:
Nit:
```suggestion
let color_schemes: ColorScheme[] = [];
if (
bootstrapData.common &&
bootstrapData.common.setup_extra &&
bootstrapData.common.setup_extra.COLOR_SCHEMES
) {
color_schemes = bootstrapData.common.setup_extra.COLOR_SCHEMES;
}
setupColors(color_schemes);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (47a846b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.57%`.
> The diff coverage is `5.26%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 62.62% -3.58%
==========================================
Files 996 1002 +6
Lines 49174 49233 +59
Branches 4993 5005 +12
==========================================
- Hits 32554 30833 -1721
- Misses 16476 18200 +1724
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.21% <0.00%> (+0.09%)` | :arrow_up: |
| python | `63.54% <100.00%> (-0.68%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-56.53%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (fa8b08f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.30%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 63.89% -2.31%
==========================================
Files 996 485 -511
Lines 49174 29797 -19377
Branches 4993 0 -4993
==========================================
- Hits 32554 19039 -13515
+ Misses 16476 10758 -5718
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.89% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.89% <0.00%> (-2.48%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.44% <0.00%> (-1.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `84.27% <0.00%> (-1.81%)` | :arrow_down: |
| ... and [517 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...fa8b08f](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitmiran137 closed pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (fa8b08f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `6.99%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 59.20% -7.00%
==========================================
Files 996 947 -49
Lines 49174 46563 -2611
Branches 4993 4299 -694
==========================================
- Hits 32554 27568 -4986
- Misses 16476 18995 +2519
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.87% <100.00%> (+6.77%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.89% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/setup/setupColorsExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzRXh0cmEudHM=) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [408 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...fa8b08f](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (d6a5db0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `2.31%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 63.88% -2.32%
==========================================
Files 996 485 -511
Lines 49174 29831 -19343
Branches 4993 0 -4993
==========================================
- Hits 32554 19059 -13495
+ Misses 16476 10772 -5704
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.88% <100.00%> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.89% <0.00%> (-2.48%)` | :arrow_down: |
| ... and [522 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#discussion_r551557453
##########
File path: superset-frontend/src/setup/setupColors.js
##########
@@ -49,4 +50,6 @@ export default function setupColors() {
});
});
sequentialSchemeRegistry.setDefaultKey('superset_seq_1');
+
+ setupColorsExtra();
Review comment:
Should we pass the context here as in `setupColorsExtra({sequentialSchemeRegistry, categoricalSchemeRegistry});` or similar?
I'm also wondering if we should have a central file for all the configuration hooks, similar to `superset/config.py` on the python side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (fa8b08f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `6.83%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 59.36% -6.84%
==========================================
Files 996 947 -49
Lines 49174 46563 -2611
Branches 4993 4299 -694
==========================================
- Hits 32554 27643 -4911
- Misses 16476 18920 +2444
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.31% <100.00%> (+7.21%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.89% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/setup/setupColorsExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzRXh0cmEudHM=) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [407 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...fa8b08f](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (fa8b08f) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `7.11%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 59.08% -7.12%
==========================================
Files 996 947 -49
Lines 49174 46797 -2377
Branches 4993 4427 -566
==========================================
- Hits 32554 27650 -4904
- Misses 16476 19147 +2671
+ Partials 144 0 -144
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.65% <100.00%> (+6.55%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.89% <ø> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/setup/setupColorsExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzRXh0cmEudHM=) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [407 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...fa8b08f](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12210: feat: Custom color schemes support
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12210:
URL: https://github.com/apache/incubator-superset/pull/12210#issuecomment-754073302
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=h1) Report
> Merging [#12210](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=desc) (47a846b) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f3ab1f41eebcd8dfe0379e81dd7083f1a9efa52f?el=desc) (f3ab1f4) will **decrease** coverage by `3.23%`.
> The diff coverage is `5.26%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12210 +/- ##
==========================================
- Coverage 66.20% 62.96% -3.24%
==========================================
Files 996 1002 +6
Lines 49174 49233 +59
Branches 4993 5005 +12
==========================================
- Hits 32554 31002 -1552
- Misses 16476 18031 +1555
- Partials 144 200 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.21% <0.00%> (+0.09%)` | :arrow_up: |
| python | `64.11% <100.00%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (-56.53%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.21% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.57% <100.00%> (+0.03%)` | :arrow_up: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/12210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=footer). Last update [f3ab1f4...4d8529c](https://codecov.io/gh/apache/incubator-superset/pull/12210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org