You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/12 04:30:30 UTC
[GitHub] [trafficserver] maskit opened a new issue #7108: Comment for ats_base64_ functions seems wrong
maskit opened a new issue #7108:
URL: https://github.com/apache/trafficserver/issues/7108
The comment says functions return pointers for malloc-ed buffers, but the implementations don't seem like so.
https://github.com/apache/trafficserver/blob/c196db5f0a5b957983351ad51ef360bfc68fbd66/include/tscore/ink_base64.h#L34-L35
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on issue #7108: Comment for ats_base64_ functions seems wrong
Posted by GitBox <gi...@apache.org>.
bryancall commented on issue #7108:
URL: https://github.com/apache/trafficserver/issues/7108#issuecomment-976053428
@willwendorfvm Do you want to take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] alokrahul513 commented on issue #7108: Comment for ats_base64_ functions seems wrong
Posted by GitBox <gi...@apache.org>.
alokrahul513 commented on issue #7108:
URL: https://github.com/apache/trafficserver/issues/7108#issuecomment-778763981
Hi, I want to work on this issue. How to get started?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] yozaam commented on issue #7108: Comment for ats_base64_ functions seems wrong
Posted by GitBox <gi...@apache.org>.
yozaam commented on issue #7108:
URL: https://github.com/apache/trafficserver/issues/7108#issuecomment-678443170
* These routines convert char*'s to malloc-ed strings. The caller is
* responsible for freeing the strings.
Would that becorrect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on issue #7108: Comment for ats_base64_ functions seems wrong
Posted by GitBox <gi...@apache.org>.
maskit commented on issue #7108:
URL: https://github.com/apache/trafficserver/issues/7108#issuecomment-920453360
If you think the behavior is obvious and the comment is unnecessary, remove it.
If you think documentation is necessary, modify the comment so that it describes the behavior.
I think documentation is always nice to have, but it should not tell a lie if it exists. I'd modify the comment.
Here is the implementations if you need to know what the functions do.
https://github.com/apache/trafficserver/blob/master/src/tscore/ink_base64.cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on issue #7108: Comment for ats_base64_ functions seems wrong
Posted by GitBox <gi...@apache.org>.
maskit commented on issue #7108:
URL: https://github.com/apache/trafficserver/issues/7108#issuecomment-678846295
I think the routines do not allocate memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] Sid672 commented on issue #7108: Comment for ats_base64_ functions seems wrong
Posted by GitBox <gi...@apache.org>.
Sid672 commented on issue #7108:
URL: https://github.com/apache/trafficserver/issues/7108#issuecomment-919771290
@maskit can you tell me what changes you want?
Removal of comments or modify them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] Sid672 commented on issue #7108: Comment for ats_base64_ functions seems wrong
Posted by GitBox <gi...@apache.org>.
Sid672 commented on issue #7108:
URL: https://github.com/apache/trafficserver/issues/7108#issuecomment-920768613
@maskit please correct me if I am wrong.
Functions:
```
1) bool ats_base64_encode(const char *inBuffer, size_t inBufferSize, char *outBuffer, size_t outBufSize, size_t *length);
2) bool ats_base64_encode(const unsigned char *inBuffer, size_t inBufferSize, char *outBuffer, size_t outBufSize, size_t *length);
3) bool ats_base64_decode(const char *inBuffer, size_t inBufferSize, unsigned char *outBuffer, size_t outBufSize, size_t *length);
```
- The first function call the 2nd function.
- 2nd function converts the character into binary up to the length of Buffersize and returns true if it is completed.
- 3rd function decode the buffer and returns true after completion.
So can I add these comments:
```
* These routines convert char's of string and return true.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org