You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/02/03 15:14:00 UTC

[jira] [Commented] (KAFKA-6786) Remove additional configs in StreamsBrokerDownResilienceTest

    [ https://issues.apache.org/jira/browse/KAFKA-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759443#comment-16759443 ] 

ASF GitHub Bot commented on KAFKA-6786:
---------------------------------------

sh-abhi commented on pull request #6229: KAFKA-6786: Removing additional configs for StreamsBrokerDownResilienceTest
URL: https://github.com/apache/kafka/pull/6229
 
 
   Updated iteration of KAFKA-6786. Currently a WIP as it is my first time contributing; want to make sure that we implemented this correctly.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove additional configs in StreamsBrokerDownResilienceTest
> ------------------------------------------------------------
>
>                 Key: KAFKA-6786
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6786
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Abhishek Sharma
>            Priority: Minor
>              Labels: newbie
>
> Since we are now passing in a property file into the streams service initialization code, we do not need to pass in those configs as additional properties in StreamsBrokerDownResilienceTest. We can refactor this test to get rid of the additional properties.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)