You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by bo...@apache.org on 2012/08/02 21:52:22 UTC
android commit: I forgot that Jellybean has some wacky changes on the
onKeyUp and onKeyDown events, fixing CB-1181
Updated Branches:
refs/heads/master ecd6ca017 -> 81ab0a414
I forgot that Jellybean has some wacky changes on the onKeyUp and onKeyDown events, fixing CB-1181
Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/81ab0a41
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/81ab0a41
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/81ab0a41
Branch: refs/heads/master
Commit: 81ab0a414fba2ac949b1f8480cfbb78d7cf3d1e9
Parents: ecd6ca0
Author: Joe Bowser <bo...@apache.org>
Authored: Thu Aug 2 12:51:48 2012 -0700
Committer: Joe Bowser <bo...@apache.org>
Committed: Thu Aug 2 12:51:48 2012 -0700
----------------------------------------------------------------------
.../src/org/apache/cordova/CordovaWebView.java | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/81ab0a41/framework/src/org/apache/cordova/CordovaWebView.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaWebView.java b/framework/src/org/apache/cordova/CordovaWebView.java
index 0ce63c0..fe677f4 100755
--- a/framework/src/org/apache/cordova/CordovaWebView.java
+++ b/framework/src/org/apache/cordova/CordovaWebView.java
@@ -730,9 +730,6 @@ public class CordovaWebView extends WebView {
@Override
public boolean onKeyUp(int keyCode, KeyEvent event)
{
-
- Log.d(TAG, "KeyDown has been triggered on the view");
-
// If back key
if (keyCode == KeyEvent.KEYCODE_BACK) {
// If back key is bound, then send event to JavaScript
@@ -768,8 +765,8 @@ public class CordovaWebView extends WebView {
return super.onKeyUp(keyCode, event);
}
- Log.d(TAG, "KeyUp has been triggered on the view");
- return false;
+ //Does webkit change this behaviour?
+ return super.onKeyUp(keyCode, event);
}