You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ankita Sinha <an...@freestoneinfotech.com> on 2017/05/05 11:40:43 UTC

Review Request 59021: Code improvement to follow best practices.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59021/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1560
    https://issues.apache.org/jira/browse/RANGER-1560


Repository: ranger


Description
-------

Code improvement to follow best practices.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java 27d0e42 
  agents-common/src/main/java/org/apache/ranger/plugin/store/RangerServiceResourceSignature.java d643034 
  agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicyResourceSignature.java 345b260 
  ranger-hive-utils/src/main/java/org/apache/ranger/authorization/hive/udf/RangerUdfMaskHash.java 430212b 


Diff: https://reviews.apache.org/r/59021/diff/1/


Testing
-------

1. Tested on simple cluster for Hive and HDFS component (Test connection, resource lookup and enforcement)
2. Tested on secure cluster for Hive and HDFS component (Test connection, resource lookup and enforcement)
3. Tested CRUD operation for Service/Repo and Policies.


Thanks,

Ankita Sinha


Re: Review Request 59021: Code improvement to follow best practices.

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59021/#review174061
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On May 5, 2017, 11:40 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59021/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 11:40 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1560
>     https://issues.apache.org/jira/browse/RANGER-1560
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Code improvement to follow best practices.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java 27d0e42 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/RangerServiceResourceSignature.java d643034 
>   agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicyResourceSignature.java 345b260 
>   ranger-hive-utils/src/main/java/org/apache/ranger/authorization/hive/udf/RangerUdfMaskHash.java 430212b 
> 
> 
> Diff: https://reviews.apache.org/r/59021/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Tested on simple cluster for Hive and HDFS component (Test connection, resource lookup and enforcement)
> 2. Tested on secure cluster for Hive and HDFS component (Test connection, resource lookup and enforcement)
> 3. Tested CRUD operation for Service/Repo and Policies.
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>


Re: Review Request 59021: Code improvement to follow best practices.

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59021/#review174062
-----------------------------------------------------------


Ship it!




Ship It!

- Gautam Borad


On May 5, 2017, 11:40 a.m., Ankita Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59021/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 11:40 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1560
>     https://issues.apache.org/jira/browse/RANGER-1560
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Code improvement to follow best practices.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyResourceSignature.java 27d0e42 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/RangerServiceResourceSignature.java d643034 
>   agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerPolicyResourceSignature.java 345b260 
>   ranger-hive-utils/src/main/java/org/apache/ranger/authorization/hive/udf/RangerUdfMaskHash.java 430212b 
> 
> 
> Diff: https://reviews.apache.org/r/59021/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Tested on simple cluster for Hive and HDFS component (Test connection, resource lookup and enforcement)
> 2. Tested on secure cluster for Hive and HDFS component (Test connection, resource lookup and enforcement)
> 3. Tested CRUD operation for Service/Repo and Policies.
> 
> 
> Thanks,
> 
> Ankita Sinha
> 
>