You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/29 20:15:33 UTC
[GitHub] [airflow] potiuk opened a new pull request #18613: Update documentation for September providers release
potiuk opened a new pull request #18613:
URL: https://github.com/apache/airflow/pull/18613
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718871852
##########
File path: airflow/providers/docker/CHANGELOG.rst
##########
@@ -19,6 +19,23 @@
Changelog
---------
+2.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add a Docker Taskflow decorator (#15330)``
Review comment:
This change requires Aiirflow 2.2 which is yet to be released, so we probably shouldn't be releasing this packages yett.
##########
File path: airflow/providers/slack/CHANGELOG.rst
##########
@@ -19,6 +19,28 @@
Changelog
---------
+4.1.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718871852
##########
File path: airflow/providers/docker/CHANGELOG.rst
##########
@@ -19,6 +19,23 @@
Changelog
---------
+2.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add a Docker Taskflow decorator (#15330)``
Review comment:
This change requires Aiirflow 2.2 which is yet to be released, so we probably shouldn't be releasing this packages yett.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r719052452
##########
File path: airflow/providers/amazon/CHANGELOG.rst
##########
@@ -19,6 +19,36 @@
Changelog
---------
+2.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add IAM Role Credentials to S3ToRedshiftTransfer and RedshiftToS3Transfer (#18156)``
+* ``Adding missing 'replace' param in docstring (#18241)``
Review comment:
We seem to have issue with the escaping the single quote the `'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718857434
##########
File path: docs/apache-airflow-providers-amazon/commits.rst
##########
@@ -227,7 +253,7 @@ Commit
================================================================================================ =========== ======================================================================================================================================================================
`32971a1a2 <https://github.com/apache/airflow/commit/32971a1a2de1db0b4f7442ed26facdf8d3b7a36f>`_ 2020-12-09 ``Updates providers versions to 1.0.0 (#12955)``
`d5589673a <https://github.com/apache/airflow/commit/d5589673a95aaced0b851ea0a4061a010a924a82>`_ 2020-12-08 ``Move dummy_operator.py to dummy.py (#11178) (#11293)``
-`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaining modules to match AIP-21 (#12917)``
+`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaing modules to match AIP-21 (#12917)``
Review comment:
These are odd? That is the commit message, but why where they "fixed" before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718873508
##########
File path: airflow/providers/docker/CHANGELOG.rst
##########
@@ -19,6 +19,23 @@
Changelog
---------
+2.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add a Docker Taskflow decorator (#15330)``
Review comment:
The decorator is not functional in Airflow 2.1, but this is no harm to have it added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18613:
URL: https://github.com/apache/airflow/pull/18613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718872894
##########
File path: airflow/providers/docker/CHANGELOG.rst
##########
@@ -19,6 +19,23 @@
Changelog
---------
+2.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add a Docker Taskflow decorator (#15330)``
Review comment:
Quite the opposite - we should release them so that we can release Airflow 2.2 with this feature working. We've done that in the past - we need to release provider's first and Airflow after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r719155749
##########
File path: airflow/providers/docker/CHANGELOG.rst
##########
@@ -19,6 +19,23 @@
Changelog
---------
+2.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add a Docker Taskflow decorator (#15330)``
Review comment:
Mailing list discussion: https://lists.apache.org/thread.html/rbe2552f5c49114378a9aedb7ceee906976158d38b44e955fed18000f%40%3Cdev.airflow.apache.org%3E
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#issuecomment-930519811
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718872894
##########
File path: airflow/providers/docker/CHANGELOG.rst
##########
@@ -19,6 +19,23 @@
Changelog
---------
+2.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add a Docker Taskflow decorator (#15330)``
Review comment:
Quite the opposite - we should release them so that we can release Airflow 2.2 with this feature working. We've done that in the past - we need to release provider's first and Airflow after.
##########
File path: airflow/providers/docker/CHANGELOG.rst
##########
@@ -19,6 +19,23 @@
Changelog
---------
+2.2.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add a Docker Taskflow decorator (#15330)``
Review comment:
The decorator is not functional in Airflow 2.1, but this is no harm to have it added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r719195076
##########
File path: airflow/providers/amazon/CHANGELOG.rst
##########
@@ -19,6 +19,36 @@
Changelog
---------
+2.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add IAM Role Credentials to S3ToRedshiftTransfer and RedshiftToS3Transfer (#18156)``
+* ``Adding missing 'replace' param in docstring (#18241)``
Review comment:
Yeah :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718874628
##########
File path: airflow/providers/slack/CHANGELOG.rst
##########
@@ -19,6 +19,28 @@
Changelog
---------
+4.1.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718857434
##########
File path: docs/apache-airflow-providers-amazon/commits.rst
##########
@@ -227,7 +253,7 @@ Commit
================================================================================================ =========== ======================================================================================================================================================================
`32971a1a2 <https://github.com/apache/airflow/commit/32971a1a2de1db0b4f7442ed26facdf8d3b7a36f>`_ 2020-12-09 ``Updates providers versions to 1.0.0 (#12955)``
`d5589673a <https://github.com/apache/airflow/commit/d5589673a95aaced0b851ea0a4061a010a924a82>`_ 2020-12-08 ``Move dummy_operator.py to dummy.py (#11178) (#11293)``
-`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaining modules to match AIP-21 (#12917)``
+`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaing modules to match AIP-21 (#12917)``
Review comment:
These are odd? That is the commit message, but why where they "fixed" before?
##########
File path: docs/apache-airflow-providers-amazon/commits.rst
##########
@@ -227,7 +253,7 @@ Commit
================================================================================================ =========== ======================================================================================================================================================================
`32971a1a2 <https://github.com/apache/airflow/commit/32971a1a2de1db0b4f7442ed26facdf8d3b7a36f>`_ 2020-12-09 ``Updates providers versions to 1.0.0 (#12955)``
`d5589673a <https://github.com/apache/airflow/commit/d5589673a95aaced0b851ea0a4061a010a924a82>`_ 2020-12-08 ``Move dummy_operator.py to dummy.py (#11178) (#11293)``
-`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaining modules to match AIP-21 (#12917)``
+`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaing modules to match AIP-21 (#12917)``
Review comment:
Ah, part of https://github.com/apache/airflow/pull/18121.
##########
File path: docs/apache-airflow-providers-amazon/commits.rst
##########
@@ -227,7 +253,7 @@ Commit
================================================================================================ =========== ======================================================================================================================================================================
`32971a1a2 <https://github.com/apache/airflow/commit/32971a1a2de1db0b4f7442ed26facdf8d3b7a36f>`_ 2020-12-09 ``Updates providers versions to 1.0.0 (#12955)``
`d5589673a <https://github.com/apache/airflow/commit/d5589673a95aaced0b851ea0a4061a010a924a82>`_ 2020-12-08 ``Move dummy_operator.py to dummy.py (#11178) (#11293)``
-`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaining modules to match AIP-21 (#12917)``
+`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaing modules to match AIP-21 (#12917)``
Review comment:
These are odd? That is the commit message, but why were they "fixed" before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#issuecomment-930519811
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718857434
##########
File path: docs/apache-airflow-providers-amazon/commits.rst
##########
@@ -227,7 +253,7 @@ Commit
================================================================================================ =========== ======================================================================================================================================================================
`32971a1a2 <https://github.com/apache/airflow/commit/32971a1a2de1db0b4f7442ed26facdf8d3b7a36f>`_ 2020-12-09 ``Updates providers versions to 1.0.0 (#12955)``
`d5589673a <https://github.com/apache/airflow/commit/d5589673a95aaced0b851ea0a4061a010a924a82>`_ 2020-12-08 ``Move dummy_operator.py to dummy.py (#11178) (#11293)``
-`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaining modules to match AIP-21 (#12917)``
+`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaing modules to match AIP-21 (#12917)``
Review comment:
These are odd? That is the commit message, but why were they "fixed" before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r719052452
##########
File path: airflow/providers/amazon/CHANGELOG.rst
##########
@@ -19,6 +19,36 @@
Changelog
---------
+2.3.0
+.....
+
+Features
+~~~~~~~~
+
+* ``Add IAM Role Credentials to S3ToRedshiftTransfer and RedshiftToS3Transfer (#18156)``
+* ``Adding missing 'replace' param in docstring (#18241)``
Review comment:
We seem to have issue with the escaping the single quote the `'` it appears 15 times in the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #18613: Update documentation for September providers release
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #18613:
URL: https://github.com/apache/airflow/pull/18613#discussion_r718859699
##########
File path: docs/apache-airflow-providers-amazon/commits.rst
##########
@@ -227,7 +253,7 @@ Commit
================================================================================================ =========== ======================================================================================================================================================================
`32971a1a2 <https://github.com/apache/airflow/commit/32971a1a2de1db0b4f7442ed26facdf8d3b7a36f>`_ 2020-12-09 ``Updates providers versions to 1.0.0 (#12955)``
`d5589673a <https://github.com/apache/airflow/commit/d5589673a95aaced0b851ea0a4061a010a924a82>`_ 2020-12-08 ``Move dummy_operator.py to dummy.py (#11178) (#11293)``
-`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaining modules to match AIP-21 (#12917)``
+`b40dffa08 <https://github.com/apache/airflow/commit/b40dffa08547b610162f8cacfa75847f3c4ca364>`_ 2020-12-08 ``Rename remaing modules to match AIP-21 (#12917)``
Review comment:
Ah, part of https://github.com/apache/airflow/pull/18121.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org