You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Isaac Chiang <is...@gmail.com> on 2013/04/30 09:43:25 UTC
Review Request: CLOUDSTACK-2274 : The detail view doesn't recover from
loading status when trying to delete a zone with physical network on it
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10860/
-----------------------------------------------------------
Review request for cloudstack and Pranav Saxena.
Description
-------
According to CS' fronend logic, there is a general error handling function in cloudStack.js line 95. Hense this is a common issue for detail view when a request failed from server.
This patch try not to against current UI logic and provide a statusCode callback to capture failed request. The added callback will remove loading div from detailView.
This patch is a suggested solution to the issue.
Thanks
This addresses bug CLOUDSTACK-2274.
Diffs
-----
ui/scripts/system.js 7aa0566
Diff: https://reviews.apache.org/r/10860/diff/
Testing
-------
Test from UI and work well
Thanks,
Isaac Chiang
Re: Review Request: CLOUDSTACK-2274 : The detail view doesn't recover from
loading status when trying to delete a zone with physical network on it
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10860/#review20164
-----------------------------------------------------------
Hey Isaac , we don't hard-code the error code for call backs . The better way would be to catch the exception using thrown by the API which would make the detail view recover from loading status. Something like this -
error:function(json){
args.response.error(parseXMLHttpResponse(json));
}
This would work fine as well ! If you want , I can directly make the relevant changes in the code myself. Thanks for your patch !
- Pranav Saxena
On April 30, 2013, 7:43 a.m., Isaac Chiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10860/
> -----------------------------------------------------------
>
> (Updated April 30, 2013, 7:43 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> According to CS' fronend logic, there is a general error handling function in cloudStack.js line 95. Hense this is a common issue for detail view when a request failed from server.
> This patch try not to against current UI logic and provide a statusCode callback to capture failed request. The added callback will remove loading div from detailView.
> This patch is a suggested solution to the issue.
>
> Thanks
>
>
> This addresses bug CLOUDSTACK-2274.
>
>
> Diffs
> -----
>
> ui/scripts/system.js 7aa0566
>
> Diff: https://reviews.apache.org/r/10860/diff/
>
>
> Testing
> -------
>
> Test from UI and work well
>
>
> Thanks,
>
> Isaac Chiang
>
>
Re: Review Request: CLOUDSTACK-2274 : The detail view doesn't recover from
loading status when trying to delete a zone with physical network on it
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10860/#review20166
-----------------------------------------------------------
I have committed my changes to master , so you could probably discard this review request . Again , thanks for catching this loophole here .
- Pranav Saxena
On April 30, 2013, 7:43 a.m., Isaac Chiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10860/
> -----------------------------------------------------------
>
> (Updated April 30, 2013, 7:43 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> According to CS' fronend logic, there is a general error handling function in cloudStack.js line 95. Hense this is a common issue for detail view when a request failed from server.
> This patch try not to against current UI logic and provide a statusCode callback to capture failed request. The added callback will remove loading div from detailView.
> This patch is a suggested solution to the issue.
>
> Thanks
>
>
> This addresses bug CLOUDSTACK-2274.
>
>
> Diffs
> -----
>
> ui/scripts/system.js 7aa0566
>
> Diff: https://reviews.apache.org/r/10860/diff/
>
>
> Testing
> -------
>
> Test from UI and work well
>
>
> Thanks,
>
> Isaac Chiang
>
>
Re: Review Request: CLOUDSTACK-2274 : The detail view doesn't recover from
loading status when trying to delete a zone with physical network on it
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10860/#review20165
-----------------------------------------------------------
Commit 5811ae7e2571380ab2b2be4e64686ff3affb7364 in branch refs/heads/master from Pranav Saxena <pr...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5811ae7 ]
CLOUDSTACK-2274:Detail view loading problem when deleting a zone
- ASF Subversion and Git Services
On April 30, 2013, 7:43 a.m., Isaac Chiang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10860/
> -----------------------------------------------------------
>
> (Updated April 30, 2013, 7:43 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> According to CS' fronend logic, there is a general error handling function in cloudStack.js line 95. Hense this is a common issue for detail view when a request failed from server.
> This patch try not to against current UI logic and provide a statusCode callback to capture failed request. The added callback will remove loading div from detailView.
> This patch is a suggested solution to the issue.
>
> Thanks
>
>
> This addresses bug CLOUDSTACK-2274.
>
>
> Diffs
> -----
>
> ui/scripts/system.js 7aa0566
>
> Diff: https://reviews.apache.org/r/10860/diff/
>
>
> Testing
> -------
>
> Test from UI and work well
>
>
> Thanks,
>
> Isaac Chiang
>
>