[GitHub] [flink] bowenli86 commented on a change in pull request #8830: [FLINK-12933][sql client] support 'use catalog' and 'use database' in SQL CLI

[GitBox <gi...@apache.org>]

bowenli86 commented on a change in pull request #8830: [FLINK-12933][sql client] support 'use catalog' and 'use database' in SQL CLI
URL: https://github.com/apache/flink/pull/8830#discussion_r296875235
 
 

 ##########
 File path: flink-python/pyflink/table/table_environment.py
 ##########
 @@ -183,11 +183,29 @@ def insert_into(self, table, table_path, *table_path_continued):
         j_table_path = utils.to_jarray(gateway.jvm.String, table_path_continued)
         self._j_tenv.insertInto(table._j_table, table_path, j_table_path)
 
+    def list_catalogs(self):
+        """
+        Gets the names of all catalogs registered in this environment.
+
+        :return: List of catalog names.
+        """
+        j_catalog_name_array = self._j_tenv.listCatalogs()
+        return [item for item in j_catalog_name_array]
+
+    def list_databases(self):
+            """
 
 Review comment:
   this time it's actually a real indentation issue. I've updated https://github.com/apache/flink/pull/8829 and rebased this PR to #8829 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services