[GitHub] rymanluk commented on a change in pull request #18: nimble/ll: Portion of fixes for the nimble controller.

[GitBox <gi...@apache.org>]

rymanluk commented on a change in pull request #18: nimble/ll: Portion of fixes for the nimble controller.
URL: https://github.com/apache/mynewt-nimble/pull/18#discussion_r177720381
 
 

 ##########
 File path: nimble/controller/src/ble_ll_ctrl.c
 ##########
 @@ -689,8 +689,8 @@ ble_ll_ctrl_rx_phy_req(struct ble_ll_conn_sm *connsm, uint8_t *req,
         /* XXX: TODO: if we started another procedure with an instant
          * why are we doing this? Need to look into this.*/
 
-        /* Respond to master's phy update procedure */
-        CONN_F_PEER_PHY_UPDATE(connsm) = 1;
+        /* Let us wait for LL_PHY_UPDATE_IND */
+        ble_ll_ctrl_proc_start(connsm, BLE_LL_CTRL_PROC_PHY_UPDATE);
 
 Review comment:
   hmm you right.. will remove this patch now. need to figure out how to do it nicely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services