You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/25 09:14:36 UTC
[GitHub] [airflow] kaxil opened a new pull request #10543: Enable Black on Providers Packages
kaxil opened a new pull request #10543:
URL: https://github.com/apache/airflow/pull/10543
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-680235976
aah got your point, will do it, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sztamas commented on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
sztamas commented on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-680231216
Hi @kaxil
Could you please also update the `isort` section in `setup.cfg` to ignore the `providers` and `api_connexion` the same way you ignore them in the pre-commit hook?
A `skip_glob=*/api_connexion/**/*.py,*/providers/**/*.py` should work.
Thanks,
Tamas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-680235976
> Hi @kaxil
>
> Could you please also update the `isort` section in `setup.cfg` to ignore the `providers` and `api_connexion` the same way you ignore them in the pre-commit hook?
>
> A `skip_glob=*/api_connexion/**/*.py,*/providers/**/*.py` should work.
>
> Thanks,
>
> Tamas
I have done that here https://github.com/apache/airflow/blob/cd1f79424256f1c51e5e0d4e7031540df866dc7b/.pre-commit-config.yaml#L190-L194 already :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-679914013
Great idea to enable black on Providers first!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-679918731
> Yup already applied
Good! There is too much file to be able to load it all in Github 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-679917804
> Awesome! Should we apply black on `tests/providers`?
Yup already applied
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-681885711
Should we configure isort to be compatible with black?
https://github.com/TobKed/short_my_url_baby/blob/85d07e5ceffd568f7f5506983cd58658d24d29f9/.pre-commit-config.yaml#L6-L9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sztamas commented on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
sztamas commented on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-680253485
Thanks for the fast response! :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-681893084
It is even simpler by adding "black" profile to isort which is in https://github.com/apache/airflow/pull/9550 which applies black to entire airflow repo. Waiting till we are close to 2.0 and then do a big bang so we don't need to cherrypick anymore and can pause the PRs for that time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10543:
URL: https://github.com/apache/airflow/pull/10543
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #10543: Enable Black on Providers Packages
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10543:
URL: https://github.com/apache/airflow/pull/10543#issuecomment-680235976
> Hi @kaxil
>
> Could you please also update the `isort` section in `setup.cfg` to ignore the `providers` and `api_connexion` the same way you ignore them in the pre-commit hook?
>
> A `skip_glob=*/api_connexion/**/*.py,*/providers/**/*.py` should work.
>
> Thanks,
>
> Tamas
I have done that here https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L190-L194. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org