You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by WangTaoTheTonic <gi...@git.apache.org> on 2014/10/27 07:20:28 UTC
[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...
GitHub user WangTaoTheTonic opened a pull request:
https://github.com/apache/spark/pull/2954
[SPARK-4095][YARN][Minor]extract val isLaunchingDriver in ClientBase
Instead of checking if `args.userClass` is null repeatedly, we extract it to an global val as in `ApplicationMaster`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/WangTaoTheTonic/spark MemUnit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2954.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2954
----
commit 13bda20c2cafcb3962f74abe600fbb4a01ced88c
Author: WangTaoTheTonic <ba...@aliyun.com>
Date: 2014-10-27T06:09:41Z
extract val isLaunchingDriver in ClientBase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2954
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/2954#issuecomment-60757729
@WangTaoTheTonic I would rather not see pull requests that don't really add any value. I realize this is cleanup, but I would rather see these included in something more meaningful. For instance if you had to add one more reference to isLauncherDriver or something like that. Otherwise this just adds a lot of overhead of having to review and test, etc.. I'll commit this one but please keep that in mind for future prs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...
Posted by WangTaoTheTonic <gi...@git.apache.org>.
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/2954#issuecomment-60763871
OK I see.
发自我的 iPhone
> 在 2014年10月28日，21:51，Tom Graves <no...@github.com> 写道：
>
> @WangTaoTheTonic I would rather not see pull requests that don't really add any value. I realize this is cleanup, but I would rather see these included in something more meaningful. For instance if you had to add one more reference to isLauncherDriver or something like that. Otherwise this just adds a lot of overhead of having to review and test, etc.. I'll commit this one but please keep that in mind for future prs.
>
> —
> Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2954#issuecomment-60558131
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22278/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2954#issuecomment-60558127
[Test build #22278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22278/consoleFull) for PR 2954 at commit [`13bda20`](https://github.com/apache/spark/commit/13bda20c2cafcb3962f74abe600fbb4a01ced88c).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4095][YARN][Minor]extract val isLaunchi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2954#issuecomment-60554332
[Test build #22278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22278/consoleFull) for PR 2954 at commit [`13bda20`](https://github.com/apache/spark/commit/13bda20c2cafcb3962f74abe600fbb4a01ced88c).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org