You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/27 01:22:40 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26690: Make build-images workflow name dynamic
potiuk opened a new pull request, #26690:
URL: https://github.com/apache/airflow/pull/26690
As of today you can dynamically name your build-images workflow. This will be nice change to be able to distinguish the "tests" from build images workflows.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #26690: Make build-images workflow name dynamic
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #26690:
URL: https://github.com/apache/airflow/pull/26690#issuecomment-1259767354
Looking forward to this, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26690: Make build-images workflow name dynamic
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26690:
URL: https://github.com/apache/airflow/pull/26690#issuecomment-1259302918
Should be good to go @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26690: Make build-images workflow name dynamic
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26690:
URL: https://github.com/apache/airflow/pull/26690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26690: Make build-images workflow name dynamic
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26690:
URL: https://github.com/apache/airflow/pull/26690#issuecomment-1258851742
<img width="1003" alt="Screenshot 2022-09-27 at 03 30 04" src="https://user-images.githubusercontent.com/595491/192410458-31e4f591-b135-465e-a7f1-84ca7048d393.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #26690: Make build-images workflow name dynamic
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #26690:
URL: https://github.com/apache/airflow/pull/26690#discussion_r980778921
##########
.github/workflows/build-images.yml:
##########
@@ -17,6 +17,7 @@
#
---
name: "Build Images"
+run-name: Build images for ${{ github.event.pull_request.title }}
Review Comment:
Would it be a good idea to also include the PR number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26690: Make build-images workflow name dynamic
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26690:
URL: https://github.com/apache/airflow/pull/26690#discussion_r980885573
##########
.github/workflows/build-images.yml:
##########
@@ -17,6 +17,7 @@
#
---
name: "Build Images"
+run-name: Build images for ${{ github.event.pull_request.title }}
Review Comment:
Possibly even URL to PR. I wonder how it will look like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26690: Make build-images workflow name dynamic
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26690:
URL: https://github.com/apache/airflow/pull/26690#issuecomment-1259155302
Maybe not beutiful, but you rarely look at this workflow and having a direct link you can copy&paste is pretty useful
<img width="1385" alt="Screenshot 2022-09-27 at 10 18 43" src="https://user-images.githubusercontent.com/595491/192472745-5a93d23d-230b-4b56-ab12-fb2ebbb45818.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26690: Make build-images workflow name dynamic
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26690:
URL: https://github.com/apache/airflow/pull/26690#issuecomment-1258847794
More info here: https://github.blog/changelog/2022-09-26-github-actions-dynamic-names-for-workflow-runs/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org