[GitHub] [iceberg] kbendick commented on pull request #1579: Remove time-zone dependent call when casting a date via toLocalDate in HiveIcebergFilterFactory

[GitBox <gi...@apache.org>]

kbendick commented on pull request #1579:
URL: https://github.com/apache/iceberg/pull/1579#issuecomment-707336690


   Ok. I reverted the unit test changes and updated the code. So it seems to be passing for me now too.
   
   However, when I run this, the value of `gmtDate` is still `2015-11-11` if I print it right after it's created.
   
   The values now for expected and actual are both 16751. I also printed out the Date value generated in `leafToLiteral` and it is also `2015-11-11`.
   
    Is this expected due to the use of exclusive bounds or something?
   
   ```
   gmtDate:2015-11-11
   The constant date is 2015-11-11
   The date in leafToLiteral using daysFromDate is 16751
   expected:ref(name="date") == 16751
   actual:ref(name="date") == 16751
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org