You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/05/04 14:29:21 UTC
[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r62048444
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (success, fail, service, action, args) {
+ // Handle the case when we have an old version of splashscreen plugin to avoid the API calls failures
+ if (service === 'SplashScreen') {
+ var pluginsVersions = require("cordova/plugin_list").metadata;
+ var splashscreenVersion = pluginsVersions['cordova-plugin-splashscreen'];
+ var MIN_SPLASHSCREEN_SUPPORTED_VER = 4;
+ if (splashscreenVersion && parseInt(splashscreenVersion[0], 10) < MIN_SPLASHSCREEN_SUPPORTED_VER) {
--- End diff --
This regards to the plugin version and not to the platform' one, i.e. it should work starting with cordova-plugin-splashscreen@4 (as it will just redirect API calls to the platform).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org